Skip to content

JPERF-585: Reproduce the issue #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wyrzyk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

JPERF-585: Reproduce the issue #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/test/kotlin/com/atlassian/performance/tools/ssh/api/SshConnectionTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
package com.atlassian.performance.tools.ssh.api

import org.apache.logging.log4j.Level
import org.junit.Assert
import org.junit.Test
import java.lang.Exception
import java.time.Duration
import java.time.Instant

class SshConnectionTest {

Expand All @@ -14,4 +18,18 @@ class SshConnectionTest {
Assert.assertEquals(sshResult.output, "test\n")
}
}

@Test
fun shouldRespectTimeouts() {
SshContainer().useConnection { ssh: SshConnection ->
val start = Instant.now()
try {
ssh.execute("sleep 100", Duration.ofSeconds(1), Level.OFF, Level.OFF)
}catch (e : Exception){
//ignore
}
val executeDuration = Duration.between( start, Instant.now())
Assert.assertTrue(executeDuration < Duration.ofSeconds(10))
Copy link
Contributor

@dagguh dagguh Oct 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😲

Copy link
Contributor Author

@wyrzyk wyrzyk Oct 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that sshj sends SSH_MSG_CHANNEL_CLOSE as per https://www.ietf.org/rfc/rfc4254.txt but it doesn't receive the same message in response. Sshj waits 30 seconds before timeout. I need to Wireshark it to get more details.

Copy link
Contributor Author

@wyrzyk wyrzyk Oct 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it seems to be related to our "Could not get lock /var/lib/dpkg/lock - open (11: Resource temporarily unavailable)" problem. Ubuntu doesn't close the connection and doesn't kill the apt process.

Copy link
Contributor

@dagguh dagguh Oct 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh, that's super interesting
I'm glad you found it

}
}
}