Skip to content

Conversation

@vaerlor
Copy link
Collaborator

@vaerlor vaerlor commented Dec 27, 2025

The summary is based on Coverage.Collector with the irongut plugin.

@vaerlor vaerlor requested a review from atmoos December 27, 2025 06:17
- name: Test
run: dotnet test --configuration Release --no-build --verbosity normal
run: >
dotnet test
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just put dotnet test on the first line behind the colon? (Wouldn't github actions recognise the multiline command?)

BTW: I'm also perfectly fine with long single line commands...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong preference for starting dotnet test on a new line, so I moved it up. To me, with so many options, it's easier to read if the options are on multiple lines. Unresolve this thread if you disagree.

@atmoos
Copy link
Owner

atmoos commented Dec 28, 2025

Looks good and thanks for the PR :-)

Radu Terec and others added 8 commits December 28, 2025 21:18
The summary is based on Coverage.Collector with the irongut plugin.
Signed-off-by: Radu Terec <raduterec@betterask.erni>
Signed-off-by: Radu Terec <raduterec@betterask.erni>
…enerate it twice and it wouldn't work on Windows anyway. Change coverage folder inside source

Signed-off-by: Radu Terec <raduterec@betterask.erni>
Signed-off-by: Radu Terec <raduterec@betterask.erni>
Signed-off-by: Radu Terec <raduterec@betterask.erni>
Signed-off-by: Radu Terec <raduterec@betterask.erni>
Signed-off-by: Radu Terec <r.dev@terec.ch>
@vaerlor vaerlor force-pushed the feature/test-coverage branch from 94bc7a9 to e3a5b74 Compare December 28, 2025 20:20
Signed-off-by: Radu Terec <r.dev@terec.ch>
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
Atmoos.Quantities 84% 71%
Atmoos.Quantities.Units 97% 100%
Atmoos.Quantities.Serialization.Text.Json 94% 71%
Atmoos.Quantities.Serialization.Newtonsoft 80% 68%
Summary 86% (1160 / 1355) 71% (222 / 314)

Minimum allowed line rate is 60%

@vaerlor vaerlor merged commit 1e05362 into main Dec 28, 2025
2 checks passed
@vaerlor vaerlor deleted the feature/test-coverage branch December 28, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants