-
Notifications
You must be signed in to change notification settings - Fork 0
Add coverage summary to gitHub workflow. #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/workflows/dotnet.yml
Outdated
| - name: Test | ||
| run: dotnet test --configuration Release --no-build --verbosity normal | ||
| run: > | ||
| dotnet test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just put dotnet test on the first line behind the colon? (Wouldn't github actions recognise the multiline command?)
BTW: I'm also perfectly fine with long single line commands...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong preference for starting dotnet test on a new line, so I moved it up. To me, with so many options, it's easier to read if the options are on multiple lines. Unresolve this thread if you disagree.
|
Looks good and thanks for the PR :-) |
The summary is based on Coverage.Collector with the irongut plugin.
Signed-off-by: Radu Terec <raduterec@betterask.erni>
Signed-off-by: Radu Terec <raduterec@betterask.erni>
…enerate it twice and it wouldn't work on Windows anyway. Change coverage folder inside source Signed-off-by: Radu Terec <raduterec@betterask.erni>
Signed-off-by: Radu Terec <raduterec@betterask.erni>
Signed-off-by: Radu Terec <raduterec@betterask.erni>
Signed-off-by: Radu Terec <raduterec@betterask.erni>
Signed-off-by: Radu Terec <r.dev@terec.ch>
94bc7a9 to
e3a5b74
Compare
Signed-off-by: Radu Terec <r.dev@terec.ch>
The summary is based on Coverage.Collector with the irongut plugin.