fix: align POST day keys with user timezone - #4277
Merged
Merged
Conversation
postStreak.js now imports activeDays.js (for toUserDayKey), which imports timezone.js, which imports services/settings.js. settings.js reads PATHS.data at module scope, so any test mocking lib/fileUtils.js without PATHS.data throws on load. Both suites reach this chain transitively via lib/validation.js -> subscriptionSavings.js -> postStreak.js.
atomantic
force-pushed
the
claim/issue-4211
branch
from
August 15, 2026 14:31
8a352a3 to
ebd53fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
YYYY-MM-DDlabels.Test plan
npx vitest run --configLoader runner --bail=1 --silent=passed-only lib/postStreak.test.js services/characterMetrics.test.js services/meatspacePost.test.js services/meatspacePostTraining.test.js services/meatspacePostProgress.test.js services/meatspacePostRecommendations.test.js— 265 passed.npx vitest run --configLoader runner --bail=1 --silent=passed-only services/meatspacePostRecommendations.test.js services/meatspacePostMemory.test.js services/meatspacePostMorse.test.js services/characterSignals.test.js services/characterSkills.test.js services/meatspaceLoggingStats.test.js lib/activeDays.test.js— 232 passed.Closes #4211