feat: add ACE-Step 1.5 music engine - #4280
Merged
Merged
Conversation
Owner
Author
|
Required Antigravity review is blocked in this environment: |
atomantic
force-pushed
the
claim/issue-4232
branch
from
August 15, 2026 14:30
830e535 to
deb745b
Compare
Every other CUDA-index-using venv block in this script (MiniMax H3, MiniMax Music3) respects PORTOS_TORCH_CUDA_INDEX so a user with a different CUDA toolkit can override the pinned wheel index. The new ACE-Step 1.5 block hardcoded cu128 instead.
…den healthProbe - generate_acestep15.py now renders into a per-invocation tempfile.TemporaryDirectory (mirroring generate_acestep.py's v1 pattern) instead of writing directly into the shared PortOS music library. A stray or partial file from a failed/partial generation no longer lingers as a phantom track. - ENGINES.acestep15.healthProbe now also imports acestep.inference (the actual generation path), not just acestep.handler, so a venv missing that submodule reports unhealthy up front instead of failing generation with a bare ImportError.
The install script's post-install import check only verified acestep.handler, not acestep.inference — the module the generation sidecar actually imports. A venv with a broken inference submodule would print venv-ready at install time and only fail later at generation. Mirrors the same fix already applied to the JS-side healthProbe for this engine.
Rebasing onto main picked up issue #4200's shared-helper convention (venv_exists/venv_python) and its guard test forbidding hardcoded "$X_VENV/bin/python3" call sites outside those helpers. The ACE-Step 1.5 block predated that convention; convert it to match the sibling engines (MiniMax Music 3, AudioLDM2, ACE-Step v1), including the summary line which now references the resolved ${ACESTEP15_PY} instead of hardcoding the POSIX path.
atomantic
force-pushed
the
claim/issue-4232
branch
from
August 15, 2026 14:48
9ed29fc to
e10d15d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npm test --prefix server -- --run services/pipeline/musicGen.test.js routes/music.test.jsbash -n scripts/setup-image-video.shpython3 -m py_compile scripts/generate_acestep15.pyCloses #4232