Skip to content

fix: colocate provider effort with default model #5493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atomantic merged 1 commit into from
Aug 30, 2026
+16 −14
Merged

fix: colocate provider effort with default model #5493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions client/src/pages/AIProviders.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1502,6 +1502,17 @@ function ProviderForm({ provider, onClose, onSave, onEditProvider, allProviders
</p>
</FormField>

<EffortSelect
provider={isProcessProvider(capabilityProvider) ? capabilityProvider : null}
model={formData.defaultModel}
value={formData.effort}
onChange={(effort) => setFormData(prev => ({ ...prev, effort }))}
label="Default Effort"
hint={generationControls
? 'Reasoning effort used when a run does not specify one — passed to the local model as reasoningEffort.'
: 'Reasoning effort used when a run does not specify one.'}
/>

{/* Model Tiers */}
<div className="border-t border-port-border pt-4 mt-4">
<h4 className="text-sm font-medium text-gray-300 mb-3">Model Tiers</h4>
Expand Down Expand Up @@ -1645,17 +1656,6 @@ function ProviderForm({ provider, onClose, onSave, onEditProvider, allProviders

{activeTab === 'generation' && (
<div className="space-y-4">
<EffortSelect
provider={isProcessProvider(capabilityProvider) ? capabilityProvider : null}
model={formData.defaultModel}
value={formData.effort}
onChange={(effort) => setFormData(prev => ({ ...prev, effort }))}
label="Default Effort"
hint={generationControls
? 'Reasoning effort used when a run does not specify one — passed to the local model as reasoningEffort.'
: 'Reasoning effort used when a run does not specify one.'}
/>

<FormField label="Timeout (ms)">
<input
type="number"
Expand Down
8 changes: 5 additions & 3 deletions client/src/pages/AIProviders.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@ describe('provider reasoning defaults', () => {
renderPage();

fireEvent.click(await screen.findByRole('button', { name: 'Edit' }));
await openEditorTab('Generation');
await openEditorTab('Models');

const effort = await screen.findByLabelText('Default Effort');
expect(effort).toHaveValue('');
Expand Down Expand Up @@ -690,11 +690,12 @@ describe('provider reasoning defaults', () => {
renderPage();

fireEvent.click(await screen.findByRole('button', { name: 'Edit' }));
await openEditorTab('Generation');
await openEditorTab('Models');

const effort = await screen.findByLabelText('Default Effort');
fireEvent.change(effort, { target: { value: 'high' } });

await openEditorTab('Generation');
const thinking = screen.getByLabelText('Thinking mode');
expect(thinking).toHaveValue('true');
fireEvent.change(thinking, { target: { value: 'false' } });
Expand Down Expand Up @@ -731,9 +732,10 @@ describe('provider reasoning defaults', () => {
renderPage();

fireEvent.click(await screen.findByRole('button', { name: 'Edit' }));
await openEditorTab('Generation');
await openEditorTab('Models');

fireEvent.change(await screen.findByLabelText('Default Effort'), { target: { value: 'high' } });
await openEditorTab('Generation');
fireEvent.change(screen.getByLabelText('Temperature'), { target: { value: '0.2' } });
fireEvent.change(screen.getByLabelText('Top-P'), { target: { value: '0.9' } });
expect(screen.getByLabelText('Thinking mode')).toHaveValue('true');
Expand Down