Skip to content

fix: detect MCP boot in full TUI repaints #5503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atomantic merged 1 commit into from
Aug 31, 2026
+16 −4
Merged

fix: detect MCP boot in full TUI repaints #5503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions server/lib/tuiHandshake.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,8 +837,15 @@ export function createMcpBootTracker() {
observe(strippedText) {
if (active) return true;
if (typeof strippedText !== 'string' || !strippedText) return active;
tail = (tail + strippedText).slice(-MCP_BOOT_TAIL_CAP);
if (isMcpBootSignal(tail)) active = true;
// Search BEFORE truncating. Codex commonly sends a whole-screen repaint
// in one PTY chunk: the MCP status sits above the composer/footer, and
// that suffix alone can exceed MCP_BOOT_TAIL_CAP. Truncating first drops
// a perfectly visible `Starting MCP servers` banner and falls back to the
// ordinary three-paste budget while Codex is still booting. The retained
// tail exists only to join a marker split across consecutive chunks.
const combined = tail + strippedText;
if (isMcpBootSignal(combined)) active = true;
tail = combined.slice(-MCP_BOOT_TAIL_CAP);
return active;
},
get active() { return active; },
Expand Down
9 changes: 7 additions & 2 deletions server/services/agentTuiSpawning.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1666,8 +1666,13 @@ describe('spawnTuiAgent runtime', () => {
runSpawn({ prompt: 'evaluate our animation prompts and generate drafts' });
await flushMicrotasks();

// Codex prints its MCP-boot banner during startup → latches the boot tracker.
await capturedOnData(Buffer.from('>_ OpenAI Codex (v0.144.1)\nStarting MCP servers (0/3): codex_apps, node_repl, playwright\n'));
// Codex prints its MCP-boot banner during a whole-screen repaint. The
// composer/footer after the status line exceeds the tracker's 256-char
// cross-chunk tail in real transcripts; the tracker must search the full
// new repaint before truncating that tail, or it misses the banner and
// kills the run at the ordinary three-attempt cap.
const footer = `\n\n› Ask Codex to do anything\n\n gpt-5.6-sol high · ${'workspace footer '.repeat(24)}`;
await capturedOnData(Buffer.from(`>_ OpenAI Codex (v0.148.0)\nStarting MCP servers (1/2): codex_apps (0s • esc to interrupt)${footer}`));
await flushMicrotasks();
// Fire the paste (past prompt-delay floor + readiness idle threshold).
await vi.advanceTimersByTimeAsync(2000);
Expand Down