fix: sweep sub-44px icon buttons tree-wide and widen tap-target guard (#5904) - #6079
Merged
Conversation
…#5904) Every icon-only button with tight p-0.5/p-1/p-1.5 padding now carries min-h-[44px] min-w-[44px] inline-flex items-center justify-center, and action rows holding two of them widen from gap-1 to gap-2. Icon sizes are untouched. The a11yConventions tap-target rule moves from src/components/meatspace/ to the whole client tree (same padding-shape filter and self-probe); sibling-owned SongBook surfaces are excluded for the parallel change that owns them.
Owner
Author
|
Review status: review-blocked. The mtplx local reviewer (effort low) returned no verdict: "No model configured for mtplx reviewer — set one on the Settings → Code Reviewers page." Code and tests are otherwise shippable — full client suite green (832 files / 10161 tests). Leaving the PR open for human/CI review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sweeps the remaining sub-44px icon buttons outside MeatSpace the way #5901 did, and widens the tap-target guard to the whole client tree in the same PR.
<button>with tightp-0.5/p-1/p-1.5padding now carriesmin-h-[44px] min-w-[44px] inline-flex items-center justify-center(~230 buttons across ~120 files). Sub-44 explicit mins (min-h-[24/28/32/36/40px]) are raised to the floor rather than stacked beside it. Iconsize=values are untouched.gap-1togap-2(Loops run/stop/delete, Review queue/item rows, EntryCard-style action rows, etc.).classNametemplates the guard skips (lock toggles, feedback thumbs, star/pin toggles, mute/review toggles) found by hand in the touched rows.a11yConventions.test.js: the#5703tap-target rule moves fromsrc/components/meatspace/to the whole tree (same padding-shape filter and self-probe, sameisIconOnlyButtondefinition). Sibling-owned SongBook surfaces (pages/SongBook.jsx,pages/SongBookViewer.jsx,components/songbook/) are excluded for the parallel change that owns them.Left alone, deliberately: text-label buttons, icon buttons with no padding class or roomy
p-2+ padding, icon-only anchors, the absolutetop-0.5 right-0.5pin-star overlay on CanonCard reference thumbnails (a per-site overlay-density call), and the sibling-owned SongBook/PracticeLogger tree plus client ImageGen init-image code.Closes #5904
Test plan
npx vitest run src/a11yConventions.test.js— 50/50 pass (widened guard reports zero offenders).npm testinclient/): 832 files passed, 10161 tests passed, 2 skipped.VideoTimelineLanes.test.jsx(28px remove-target assertion → 44px floor); collocated tests of all 62 touched components with test files pass.