Render practice rating hints as visible button subtext (#6000) - #6084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Practice rating explanations in
PracticeLoggerwere hover-only (titleattribute), invisible on touch devices. Each rating button now renders its action hint as visible subtext beneath the label, in a 2x2 grid on phones (4-up onsm+) with >= 48px touch targets. The redundanttitletooltip was removed since the hint is always visible (avoids double-announcement in screen readers). Button accessible names now include both label and hint.Closes #6000
Test plan
npx vitest run src/components/songbook/PracticeLogger.test.jsx— 7 passed, including new test asserting all four hints render visibly.npx vitest run src/components/songbook/(full songbook dir) — 131 passed across 9 files.npx vitest run src/responsiveGridConventions.test.js src/popoverClampConventions.test.js— passed (grid usesgrid-cols-2 sm:grid-cols-4, phone-first with breakpoint).title) — addressed, re-tested.