collapse the relaunch dialog's task prompt behind a Show more toggle - #6089
Merged
Conversation
The Relaunch Agent dialog rendered the agent's whole task description inline. That description is the run's full prompt — routinely hundreds of lines — so on a phone it pushed the target-app picker, the provider/model selects and the Relaunch button far below the fold, turning a four-control dialog into a long scroll. It now opens on a three-line clamp via the shared CollapsibleText, and expanding swaps in a height-capped scroll box rather than unclamping in place, so reading the prompt never buries the controls the dialog exists for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CollapsibleText, matching whatAgentCardalready does for the same field.max-h-48 overflow-y-auto) rather than unclamping in place, so reading the prompt never re-buries the controls the dialog exists for.Test plan
client/src/components/cos/tabs/RelaunchAgentModal.test.jsx— new case asserts the preview opens clamped, that expanding drops the clamp for the capped scroll box, and that the Show less affordance stays reachable. The prototypescrollHeightspy now restores in anafterEachso a failed assertion can't leak it into the neighbouring tests.npx vitest run src/components/cos/tabs src/preWrapClasses.test.js src/a11yConventions.test.js src/responsiveGridConventions.test.js— 29 files, 381 tests, all passing.