hoist the SongBook import Save action into PageHeader so it stays above the fold - #6090
Merged
Conversation
…ve the fold (#6001) On a ~375px viewport the form's Save sits below the tab bar, a 12-row textarea and a 50vh live preview — roughly 1000px down, so a user who pastes a tab has to scroll three viewports to submit and back again to edit. SongBookViewer already keeps its Save in PageHeader; mirror that. The form's submit button stays put so Enter-to-submit and the bottom-of-form path keep working, and the back link's label collapses on mobile to make room for the new button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PageHeaderon/songbook/import, so the screen's main action is reachable above the fold. On a ~375px viewport it previously sat below the tab bar, a 12-row textarea and a 50vh live preview — roughly 1000px down.SongBookViewer, which already keeps its Save inPageHeader.saving || !contentText.trim()) and surfaces the existingsaveHintas its tooltip.hidden sm:inline) to make room, as the viewer does.Closes #6001
Test plan
cd client && npm test -- src/pages/SongBookImport.test.jsx— 15 passed, noact()warnings. New case asserts the header Save is disabled with an empty draft, enables after a paste, and creates the song when clicked.cd client && npm run lint— clean.