fix: fableLoom asset manifest omits playbackAssets video clips - #6110
Merged
atomantic merged 1 commit intoSep 3, 2026
Merged
Conversation
…ntic#6006) buildFableLoomAssetManifest only collected video ids from the legacy node.videoHistoryId field, so a scene render's entry clip, hold-loop clips, and per-transition exit clips (all under node.playbackAssets) never made it into the peer-sync manifest and were silently dropped from federation. Collects ids from entryVideoHistoryId, holdLoopVideoHistoryIds[], and Object.values(exitByTransition) as well, deduping against the legacy field. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
atomantic
approved these changes
Sep 3, 2026
atomantic
left a comment
atomantic
left a comment
Owner
There was a problem hiding this comment.
Reviewed against the live schema/behavior — change is correct, focused, and covered by tests. Approving.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildFableLoomAssetManifest(server/services/sharing/peerSyncAssets.js) only collected video ids from the legacynode.videoHistoryIdfield.node.playbackAssets(entryVideoHistoryId,holdLoopVideoHistoryIds[], and per-transitionexitByTransition), none of which were ever included — so those clips were silently dropped from the peer-sync manifest and never federated to peers.playbackAssetssources in addition to the legacy field, deduping against it (a video id shared across both only produces one manifest entry).Test plan
server/services/sharing/peerSyncAssets.test.js— 24/24, including 2 new tests: entry/hold/exit clips are all included, and a shared id acrossvideoHistoryIdandplaybackAssetsdedupes correctly🤖 Generated with Claude Code