Conversation
- Build once, cache artifacts, then run all tests in parallel - Version bump only runs after ALL tests pass (unit, integration, scraper) - Remove separate test.yml workflow to avoid confusing parallel runs
There was a problem hiding this comment.
Pull request overview
This PR fixes two CI workflow issues discovered after the v0.3.21 release and includes a version bump to v0.3.22. The scraper tests were failing because the Playwright webServer command (npm start) requires the compiled server code, and the release workflow was cherry-picking the wrong commit when merging changelog updates back to main.
Changes:
- Added
npm run buildstep to scraper tests workflow to compile server before Playwright starts the webServer - Fixed release workflow cherry-pick by storing the changelog commit SHA before switching branches
- Bumped version from 0.3.21 to 0.3.22 across all packages
- Corrected v0.3.21 changelog placeholders (v0.3.x → v0.3.21)
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/test.yml |
Added build step before scraper tests to ensure server dist files exist |
.github/workflows/release.yml |
Store changelog commit SHA before branch checkout to fix cherry-pick target |
package.json |
Version bump to 0.3.22 |
package-lock.json |
Version bump to 0.3.22 |
shared/package.json |
Version bump to 0.3.22 |
server/package.json |
Version bump to 0.3.22 |
client/package.json |
Version bump to 0.3.22 |
.changelog/v0.3.21.md |
Fixed version placeholders from v0.3.x to v0.3.21 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- push to dev: runs tests + version bump - pull_request to main: runs tests only (gate for merge) - Added concurrency group to cancel duplicate runs
Node.js ES modules require .js extensions in imports, but TypeScript with moduleResolution 'bundler' doesn't add them. Using tsx handles module resolution at runtime, matching the dev environment.
Scraper tests use mock servers, don't need webServer. E2E tests need the real server via webServer config.
atomantic
added a commit
that referenced
this pull request
Apr 28, 2026
- Phase 18 foundation, issue-resolution engine, and Audit Dashboard UI all confirmed complete in code; archived to DONE.md - 'Next Up' #3 now scopes the remaining auditor checks (place_mismatch, name_mismatch, missing_parents, duplicate_suspect, stale_record) — types are declared but walker isn't wired - Add auditor-agent.service.ts (1233 lines) to god-file regression list - Replace stale 'adopt buildLifespan' DRY item with the one remaining duplicate (sync.service.ts)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI workflow issues and consolidates into a single pipeline for clearer execution flow.
Changes
Consolidated CI Pipeline - Merged separate
test.ymlintoci.yml:Fixed Scraper Tests - Added build artifact restoration (previously missing the server build)
Fixed Release Workflow - Store changelog commit SHA before switching branches to fix cherry-pick failure on merge commits
Pipeline Flow
Version bump is now gated on all tests passing, preventing the confusing situation where version bumps succeed while tests fail.
Test Plan