fix: clean up event listeners and timers in React hooks - #43
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes two memory-leak-related cleanup issues in React hooks/components. In useSSE.ts, named SSE event listeners are now properly tracked and removed via removeEventListener before the EventSource is closed. In CopyButton.tsx, a useRef holds the debounce timer ID so it can be cleared both when a new copy action fires and when the component unmounts.
Changes:
- Introduced a
listenersarray inuseSSE.tsto track and explicitly remove named event listeners in the effect cleanup. - Added
useRef+useEffectinCopyButton.tsxto cancel any pendingsetTimeouton unmount, preventing a state update on an unmounted component.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
client/src/hooks/useSSE.ts |
Tracks named event listeners and calls removeEventListener for each before closing the EventSource. |
client/src/components/ui/CopyButton.tsx |
Stores the setTimeout handle in a ref so it can be cancelled both on subsequent copies and on unmount. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better Audit — Stack-Specific (React)
2 findings fixed across 2 files. Added removeEventListener cleanup in useSSE hook (memory leak fix). Added setTimeout cleanup in CopyButton.