TS: static is() type guard on profile classes#147
Merged
Conversation
Adds a cheap, non-throwing type guard to generated profile classes so callers can filter collections without hand-rolling resourceType predicates or relying on from() throwing. Emitted only when the profile can be meaningfully discriminated: - resource profiles with a meta field — check resourceType + meta.profile - extension profiles — check url === canonicalUrl Skipped otherwise, since a check of only resourceType (or always-true) would be a misleading guard.
- Regenerated profile classes for R4 examples (Observation profiles and Extension profiles) pick up the new is() method. - Added demo + regression tests for is() showing the filter pattern from issue #146.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #146.
Summary
static is(resource: unknown): resource is BaseTypeon profile classes for ergonomic collection filtering without hand-rollingresourceTypepredicates or relying onfrom()throwing.meta) — checkresourceType+meta.profile.includes(canonicalUrl)url === canonicalUrlresourceType(or always-true) would be a misleading guard.Usage
The motivating example from the issue collapses to:
Generated output (resource profile)
Generated output (extension profile)