Conversation
ryukzak
requested changes
Dec 24, 2025
Collaborator
ryukzak
left a comment
ryukzak
left a comment
There was a problem hiding this comment.
Let's make two examples here (don't need to push both fully to repo): for a simple client and for a FHIRPY client.
fhirpy: created a separate generation file for fhirpy
ryukzak
requested changes
Dec 29, 2025
| export class Python extends Writer<PythonGeneratorOptions> { | ||
| private readonly nameFormatFunction: (name: string) => string; | ||
| private tsIndex: TypeSchemaIndex | undefined; | ||
| private readonly forFhirpyClient: boolean; |
Collaborator
There was a problem hiding this comment.
Just a question, not a call for action: maybe we can generalize it and allow users to pass not only classes from assets, but a custom user class too?
I don't have an idea how to do it without overengineering, but maybe you have?
injectSuperClasses now checks canonical urls instead of names
ryukzak
requested changes
Jan 19, 2026
Collaborator
ryukzak
left a comment
ryukzak
left a comment
There was a problem hiding this comment.
Looks good, but can we make some changes:
- Let’s put Python and FHIRPy examples in different paths; it will simplify layouts. We don't need to put all generated code in the example for both of them.
- Please update the example list in the readme.
- Can you call mypy on the example code and generated code?
…ories ci, py: mypy runs on all example files py: updated READMEs
ryukzak
approved these changes
Jan 27, 2026
ryukzak
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.