Determine paths for ESP32 mkimage.sh at runtime #2052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from CMAKE_BINARY_DIR found when configuring with cmake to determining the paths at runtime. This allows configuring and building with the espressif/esp-idf docker image, and later running the escript in the host environment with OTP (and optionally Elixir and/or Gleam) installed. Signed-off-by: Winford <winford@object.stream>
bettio
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from CMAKE_BINARY_DIR found when configuring with cmake to determining the paths at runtime. This allows configuring and building with the espressif/esp-idf docker image, and later running the escript in the host environment with OTP (and optionally Elixir and/or Gleam) installed.
These changes are needed for atomvm/exatomvm#65.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later