fix(benchmark): drop invalid focus token and phantom model IDs in corpus.yml#162
Merged
Merged
Conversation
…pus.yml - Remove `does_it_work` from matrix.focus (not a registered FOCUS_AREAS key) - Update trailing comment above `focus:` to remove reference to does_it_work - Remove `gemini-2.5-flash-lite` and `gemini-3.1-pro-preview` (no MODEL_PRICING entries) - Correct `gemini-3-flash` → `gemini-3-flash-preview` (actual pricing key) - Correct `gpt-5.2` → `gpt-5.4` (actual pricing key) - Add TestCorpusYmlFocusTokens and TestCorpusYmlModelIds to test_benchmark.py to guard against regressions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jeff-atriumn
force-pushed
the
worktree-cheerful-mapping-curry
branch
from
d7c496b to
60f37c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
does_it_workfrommatrix.focus— it is not a key inFOCUS_AREASand causesValueError: Unknown focus areaat runtimefocus:to stop describingdoes_it_workgemini-2.5-flash-liteandgemini-3.1-pro-preview— neither has aMODEL_PRICINGentrygemini-3-flash→gemini-3-flash-preview(actual pricing key)gpt-5.2→gpt-5.4(actual pricing key)TestCorpusYmlFocusTokensandTestCorpusYmlModelIdsintests/test_benchmark.pyto guard against regressionsTest plan
pytest tests/test_benchmark.py— all 24 tests pass, including the 3 new corpus validation testspytest— 444/444 passCloses #159