Skip to content

feat: add support for populating and using sharedKeyEnc#376

Merged
gkc merged 2 commits intotrunkfrom
include_encryption_key_in_metadata
Mar 25, 2026
Merged

feat: add support for populating and using sharedKeyEnc#376
gkc merged 2 commits intotrunkfrom
include_encryption_key_in_metadata

Conversation

@akafredperry
Copy link
Copy Markdown
Collaborator

@akafredperry akafredperry commented Mar 24, 2026

closes #367

- What I did

  • Updated Java SDK to support shared encryption keys in the metadata (removing the need for sharedWith atSign to perform lookup to get the shared key, although that feature is retained as a fallback)
  • Expanded tests for EncryptionUtils
  • Added support for client config which set the SDK version and platform for the session
  • Added support for JSON formatted error messages
  • Minor usability feature for setting AtKeys

- How I did it

  • Updated Metadata to include all the fields that are currently supported by the server
  • Fixed bug in update params marshalling code (sharedKeyEnc was out of order)
  • Enhanced SharedKeyCommands and Notifications to support sharedKeyEnc (and pubKeyhash, pubKeyCS)
  • Added ClientConfig map to AuthenticatorCommands - client version will be populated from maven artifact version, clientId is UUID, platform is Java

- How to verify it

  • Unit and Integration tests have been expanded to cover all the changes (these run as part of this pipeline) - coverage threshold has been increased to 80%
  • Have tested put/get from Dart CLI and Java SDK

- Description for the changelog

support shared encryption keys in the metadata

@akafredperry akafredperry self-assigned this Mar 24, 2026
@akafredperry akafredperry requested a review from gkc March 24, 2026 17:53
Copy link
Copy Markdown
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @akafredperry I think a good next step would be to implement at_talk in Java to verify interop of all of the core functionality

@gkc gkc merged commit 5942ab1 into trunk Mar 25, 2026
4 checks passed
@gkc gkc deleted the include_encryption_key_in_metadata branch March 25, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shared Keys should include the encryption key in the metadata

2 participants