Elasticsearch helm chart by renmak · Pull Request #10 · att-comdev/openstack-helm-addons

renmak · 2017-04-20T17:24:13Z

@wilkers-steve @v1k0d3n
Elasticsearch helm chart.

Status: Ready for review.

wilkers-steve

This is a solid start @renmak. I've left a few comments inline

wilkers-steve · 2017-04-24T15:03:07Z

elasticsearch/Chart.yaml

@@ -0,0 +1,4 @@
+apiVersion: v1
+description: A Helm chart for Kubernetes


We'll want the description to read "A helm chart for elasticsearch", or some variant

wilkers-steve · 2017-04-24T15:21:09Z

elasticsearch/templates/deployment-es-master.yaml

+      annotations:
+        pod.beta.kubernetes.io/init-containers: '[
+          {
+          "name": "sysctl",


This init container isn't necessary. Elasticsearch has two methods for changing heap size: the first is via the ES_HEAP_SIZE environment variable, and the second is with JVM flags. The example used here (ES_JAVA_OPTS) sets these for the container already. We should look to see what the contents of the elasticsearch configuration file include to provide a method to override the default configuration values through a templated config file in a confmap, or we should make sure the environment variables used in the current approach can be customized through values.yaml

wilkers-steve · 2017-04-24T15:22:22Z

elasticsearch/templates/deployment-es-data.yaml

+        role: {{ .Values.labels.es_data.role }}
+      annotations:
+        pod.beta.kubernetes.io/init-containers: '[
+          {


See comment regarding heap size wrt this init container

wilkers-steve · 2017-04-24T15:23:45Z

elasticsearch/templates/deployment-es-master.yaml

+        - name: "CLUSTER_NAME"
+          value: "myesdb"
+        - name: "NUMBER_OF_MASTERS"
+          value: "2"


These environment variables should be configurable where it makes sense. For example here, we'd want to make sure NUMBER_OF_MASTERS matches the actual replicas of es-master pods.

wilkers-steve · 2017-05-22T16:24:28Z

elasticsearch/templates/_helpers.tpl

@@ -0,0 +1,16 @@
+{{/* vim: set filetype=mustache: */}}


I don't see these two partial templates used anywhere. If they're unnecessary, they should be removed

Yes will delete this file if no usage found. Keeping it right now just in case if needed.

wilkers-steve · 2017-05-22T16:28:01Z

elasticsearch/templates/deployment-es-data-stateful.yaml

+# limitations under the License.
+
+apiVersion: apps/v1beta1
+kind: StatefulSet


I'm not sure we need this to be a StatefulSet. Each of the components should be the same kind (statefulset vs deployment)

wilkers-steve · 2017-05-22T16:31:55Z

elasticsearch/templates/deployment-es-data-stateful.yaml

+        volumeMounts:
+        - name: storage
+          mountPath: /data
+  volumeClaimTemplates:


Any manifests for the volume claims should be separate templates

wilkers-steve · 2017-05-22T16:32:58Z

elasticsearch/templates/deployment-es-data-stateful.yaml

+        securityContext:
+          privileged: true
+          capabilities:
+            add:


The SYS_RESOURCE capability will need to be added to lock memory appropriately when elasticsearch is set up

wilkers-steve · 2017-05-22T16:37:19Z

elasticsearch/templates/deployment-es-client.yaml

+              - IPC_LOCK
+              - SYS_RESOURCE
+        image: {{ .Values.images.elasticsearch }}
+        imagePullPolicy: {{ .Values.images.pullPolicy }}


The ability to enable resources and template the values for limits and requests should be included, as in the other charts

wilkers-steve · 2017-05-22T16:48:59Z

elasticsearch/values.yaml

+cluster_name: myesdb
+
+images:
+  elasticsearch: quay.io/pires/docker-elasticsearch-kubernetes:5.3.0


While this image works currently, we need to determine our reference image. Kolla has been the reference for our OpenStack images, but I don't know how well maintained Elasticsearch is on their end. This matters because Elasticsearch and Kibana's versions are tightly coupled, and we don't want either one to be out of sync with the other.

wilkers-steve · 2017-05-22T17:33:45Z

elasticsearch/templates/storage-class.yaml

+# limitations under the License.
+
+kind: StorageClass
+apiVersion: storage.k8s.io/v1beta1


StorageClass is v1 now

wilkers-steve · 2017-05-22T17:37:19Z

elasticsearch/templates/deployment-es-client.yaml

+        volumeMounts:
+        - name: storage
+          mountPath: /data
+      volumes:


To use an empty directory for storage here, it should be

name: storage
emptyDir: {}

wilkers-steve · 2017-05-22T17:37:49Z

elasticsearch/templates/deployment-es-master.yaml

+        - name: storage
+          mountPath: /data
+      volumes:
+          - emptyDir:


Similar to above, this approach for using an emptyDir needs to change

wilkers-steve · 2017-05-22T17:38:24Z

elasticsearch/templates/deployment-es-master.yaml

+        - name: "CLUSTER_NAME"
+          value: {{ .Values.cluster_name }}
+        - name: "NUMBER_OF_MASTERS"
+          value: {{ .Values.replicas.es_master }}      #Should we use "" string here or just as number?


This inline comment should be removed

renmak · 2017-05-23T21:24:45Z

To reviewer: As of right now we have working version of ES chart. We are using emptyDir for storage. We plan to make further changes in future.

alanmeadows · 2017-06-16T04:19:49Z

@renmak, Should this be closed as it would likely be destined for github.com/openstack/... at this point?

wilkers-steve suggested changes Apr 24, 2017

View reviewed changes

renmak changed the title ~~Elasticsearch helm chart (WIP)~~ WIP - Elasticsearch helm chart May 1, 2017

wilkers-steve suggested changes May 22, 2017

View reviewed changes

Adding Elasticsearch helm chart.

d7bac99

renmak force-pushed the elasticsearch-helm-chart branch from 24a3d9c to d7bac99 Compare May 23, 2017 21:13

renmak changed the title ~~WIP - Elasticsearch helm chart~~ Elasticsearch helm chart May 23, 2017

		@@ -0,0 +1,4 @@
		apiVersion: v1
		description: A Helm chart for Kubernetes

Conversation

renmak commented Apr 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wilkers-steve left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

renmak commented May 23, 2017

Uh oh!

alanmeadows commented Jun 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

renmak commented Apr 20, 2017 •

edited

Loading