Harden cloud env setup script against the web setup-script contract#66
Merged
Conversation
…ract Verified against https://code.claude.com/docs/en/claude-code-on-the-web: - never block session start: steps are non-fatal and the script exits 0 (a non-zero exit makes the session fail to start) - rely on pre-installed runtimes (Rust/Node/Bun/Docker); drop redundant apt - persist PATH for the session via $CLAUDE_ENV_FILE - keep runtime within the ~5 minute environment-cache budget Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Review finding:
No other material issues found in the diff. |
# Conflicts: # scripts/setup-claude-env.sh
88b99cc to
ec3aa09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #64. Hardens
scripts/setup-claude-env.shagainst the verified Claude Code on the web setup-script contract:exit 0.apt-getinstall is gone (less to fail under restricted networking).$CLAUDE_ENV_FILEwhen rustup installs to a fresh location.🤖 Generated with Claude Code