Skip to content

Fix tag comparison (numerical order) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sgrimard wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix tag comparison (numerical order) #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/git_conventional_version/versioning/releases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def _get_version_strings(self) -> List[str]:
def _sort_version_strings(self, version_strings: List[str]) -> List[str]:
return sorted(
version_strings,
key=lambda x: tuple(re.findall(r'\d+', x)),
key=lambda x: tuple([int(i) for i in re.findall(r'\d+', x)]),
reverse=True
)

Expand Down Expand Up @@ -113,4 +113,4 @@ class AlphaRelease(PreRelease):
class BetaRelease(PreRelease):
"""Handles beta versions specifically.
"""
version_class = BetaVersion
version_class = BetaVersion