Use version of load() with option handling for window.loadAudio#22
Open
ben-denham wants to merge 1 commit intoaudiojs:masterfrom
Open
Use version of load() with option handling for window.loadAudio#22ben-denham wants to merge 1 commit intoaudiojs:masterfrom
ben-denham wants to merge 1 commit intoaudiojs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into the following error when attempting to use
window.loadAudio()from a browser environment:Uncaught TypeError: options.fetch is not a function.This seems to be because the
window.loadAudio()function isload()inloads.js, which doesn't handle options like the function exported frombrowser.js.This pull request resolves the issue by assigning the function exported from
browser.jstowindow.loadAudio()instead.