Fix KeyError when GitHub repo move response lacks full_name#3630
Fix KeyError when GitHub repo move response lacks full_name#3630HimasreeKolathur24 wants to merge 1 commit intoaugurlabs:mainfrom
Conversation
fbbbfe8 to
4125cd4
Compare
MoralCode
left a comment
There was a problem hiding this comment.
Overall I think the core change here is a good start, but
- id like to understand the reason why the API can return data without
full_nameas that will help inform how we handle things - there are a lot of unrelated formatting changes in this PR that make me a little nervous about the possibility of accidentally changing things. Did those come from your editor? or were they somehow derived from our own existing linter rules?
Signed-off-by: Himasree Kolathur <himaa@Himasrees-MacBook-Air.local>
ec3f78b to
4b267c6
Compare
|
@MoralCode, |
|
All the specific code feedback has been addressed, sure. But im still unsure what causes this full_name field to be missing in the first place. Without understanding that, its very hard to evaluate whether this is the correct solution to the issue. I would like to see more information posted in the underlying issue that provides a root cause analysis for the issue before this pr can move forward |
|
@MoralCode, |
|
I did some digging into this and came up with a different PR to help confirm my theory for why this is happening. Can you take a look and close this PR if you think that is a better solution? |
|
This is currently waiting on a re-visit after evaluating the logs of this failure after the next release |
This PR fixes a crash in the GitHub repository move detection task that occurred
when the GitHub API redirect response did not include the
full_namefield.Previously, the code assumed
full_namewas always present and raised aKeyErrorwhen it was missing. This PR makes the logic more defensive by:full_nameThis improves robustness when GitHub returns partial or unexpected redirect
metadata.
This PR fixes
Fixes #3621
Notes for Reviewers
full_nameis presentSigned commits