Skip to content

Changes to address build issues #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Adamcbrz wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Changes to address build issues #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
27a0398
Restructered plugin and addressed issue with building
Adamcbrz Sep 25, 2020
f58e26c
Update SimpleMinMaxSlider.unitypackage
Adamcbrz Sep 25, 2020
51389e3
Removed test files
Adamcbrz Sep 25, 2020
1f388a4
Copied over change suggested from VolodymyShabala
Adamcbrz Sep 25, 2020
469a3ac
Changed Readme to reference this repo
Adamcbrz Sep 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...ts/SimpleMinMaxSlider/Scripts/Editor.meta → Assets/SimpleMinMaxSlider/Editor.meta
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...ider/Scripts/Editor/MinMaxSliderDrawer.cs → ...MinMaxSlider/Editor/MinMaxSliderDrawer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ public override void OnGUI(Rect position, SerializedProperty property, GUIConten
minMaxAttribute.min,minMaxAttribute.max);

if(minVal < minMaxAttribute.min){
maxVal = minMaxAttribute.min;
minVal = minMaxAttribute.min;
}

if(minVal > minMaxAttribute.max){
if(maxVal > minMaxAttribute.max){
maxVal = minMaxAttribute.max;
}

Expand Down
0 ...Scripts/Editor/MinMaxSliderDrawer.cs.meta → ...xSlider/Editor/MinMaxSliderDrawer.cs.meta
View file
Open in desktop
File renamed without changes.
17 changes: 17 additions & 0 deletions Assets/SimpleMinMaxSlider/Editor/SimpleMinMaxSlider.Editor.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"name": "SimpleMinMaxSlider.Editor",
"references": [
"GUID:4099e5319e98558428028d54bc62664e"
],
"includePlatforms": [
"Editor"
],
"excludePlatforms": [],
"allowUnsafeCode": false,
"overrideReferences": false,
"precompiledReferences": [],
"autoReferenced": true,
"defineConstraints": [],
"versionDefines": [],
"noEngineReferences": false
}
7 changes: 7 additions & 0 deletions Assets/SimpleMinMaxSlider/Editor/SimpleMinMaxSlider.Editor.asmdef.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Assets/SimpleMinMaxSlider/Scripts.meta → Assets/SimpleMinMaxSlider/Runtime.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 ...axSlider/Scripts/MinMaxSliderAttribute.cs → ...axSlider/Runtime/MinMaxSliderAttribute.cs
View file
Open in desktop
File renamed without changes.
0 ...der/Scripts/MinMaxSliderAttribute.cs.meta → ...der/Runtime/MinMaxSliderAttribute.cs.meta
View file
Open in desktop
File renamed without changes.
0 ...pleMinMaxSlider/SimpleMinMaxSlider.asmdef → ...xSlider/Runtime/SimpleMinMaxSlider.asmdef
View file
Open in desktop
File renamed without changes.
0 ...nMaxSlider/SimpleMinMaxSlider.asmdef.meta → ...er/Runtime/SimpleMinMaxSlider.asmdef.meta
View file
Open in desktop
File renamed without changes.
9 changes: 9 additions & 0 deletions Logs/Packages-Update.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,12 @@ The following packages were updated:
com.unity.timeline from version 1.1.0 to 1.2.9
The following packages were removed:
com.unity.package-manager-ui@2.2.0

=== Fri Sep 25 09:32:24 2020

Packages were changed.
Update Mode: updateDependencies

The following packages were updated:
com.unity.ide.vscode from version 1.1.3 to 1.1.4
com.unity.test-framework from version 1.1.9 to 1.1.13
4 changes: 2 additions & 2 deletions Packages/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"com.unity.collab-proxy": "1.2.16",
"com.unity.ext.nunit": "1.0.0",
"com.unity.ide.rider": "1.1.4",
"com.unity.ide.vscode": "1.1.3",
"com.unity.test-framework": "1.1.9",
"com.unity.ide.vscode": "1.1.4",
"com.unity.test-framework": "1.1.13",
"com.unity.textmeshpro": "2.0.1",
"com.unity.timeline": "1.2.9",
"com.unity.ugui": "1.0.0",
Expand Down
4 changes: 2 additions & 2 deletions ProjectSettings/ProjectVersion.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
m_EditorVersion: 2019.3.0f5
m_EditorVersionWithRevision: 2019.3.0f5 (44796c9d3c2c)
m_EditorVersion: 2019.3.10f1
m_EditorVersionWithRevision: 2019.3.10f1 (5968d7f82152)
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

1. Open package manager
2. Add package from git URL
3. Paste: https://github.com/GucioDevs/SimpleMinMaxSlider.git#upm (remember the #upm at the end)
3. Paste: https://github.com/Adamcbrz/SimpleMinMaxSlider.git#upm (remember the #upm at the end)
4. Let Unity do its thing
5. Done.

Expand Down
Binary file modified SimpleMinMaxSlider.unitypackage
View file
Open in desktop
Binary file not shown.