UPSTREAM PR #30863: Add valgrind CT support to ML-DSA#675
Open
loci-dev wants to merge 5 commits into
Open
Conversation
added 5 commits
April 16, 2026 20:02
Also slightly refactor the ML-KEM version to share the necesasry defines, and add a daily CI run to check both (presently, for just some platforms with known working valgrind support).
Don't declassify rho_prime, that needs to stay protected.
Move constish_time_non_zero() to <internal/constant_time.h> as requested by reviewers, and rename it constish_time_true(), better reflecting the expected 0/1 boolean input.
- New CONSTTIME_SECRET_VECTOR() and CONSTTIME_DECLASSIFY_VECTOR() macros simplify CT labeling of ML-DSA vectors and avoid incorrect sizing. - New constant_time_declassify_u32() inline function mirrors a similar function in BoringSSL, with this we declassify the output pass/fail of rejection tests, rather than its numeric inputs, matching similar code in BoringSSL.
Use rank not 2 in ML-KEM decap classify_bytes
loci-dev
had a problem deploying
to
PROD__AL_DEMO
GitHub Actions
Failure
loci-dev
force-pushed
the
main
branch
5 times, most recently
from
421b135 to
770bf14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: openssl/openssl#30863
Also slightly refactor the ML-KEM version to share the necesasry defines, and add a daily CI run to check both (presently, for just some platforms with known working valgrind support).
Checklist