UPSTREAM PR #30441: ssl/quic/quic_port.c: fix leak in port_make_channel()#687
Open
loci-dev wants to merge 1 commit into
Open
UPSTREAM PR #30441: ssl/quic/quic_port.c: fix leak in port_make_channel()#687loci-dev wants to merge 1 commit into
loci-dev wants to merge 1 commit into
Conversation
Free pre-existing ch->qlog_title before OPENSSL_strdup to avoid leaking the value allocated in ossl_quic_channel_alloc(). Use ossl_quic_channel_free() on strdup failure to ensure proper cleanup. Solves openssl/openssl#30440 Fixes #30440 Signed-off-by: huanghuihui0904 <625173@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: openssl/openssl#30441
Replace OPENSSL_free(ch) with ossl_quic_channel_free(ch) on failure paths to ensure channel resources are fully released.
Solves openssl/openssl#30440
Fixes #30440