UPSTREAM PR #27110: Make CodedOutputStream.computeLengthDelimitedFieldSize public#158
Open
loci-dev wants to merge 1 commit into
Open
Conversation
This method was already used internally by all computeXxxSizeNoTag methods for length-delimited types. Exposing it lets callers who hand-construct length-delimited fields avoid repeating the computeUInt32SizeNoTag(len) + len pattern.
|
No meaningful performance changes were detected across 10164 analyzed functions in the following binaries: build.protoc-stable. 💬 Questions? Tag @loci-dev |
loci-dev
force-pushed
the
main
branch
7 times, most recently
from
f292971 to
1fdfb93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: protocolbuffers/protobuf#27110
This method was already used internally by all
computeXxxSizeNoTagmethods for length-delimited types. Exposing it lets callers who hand-construct length-delimited fields avoid repeating thecomputeUInt32SizeNoTag(len) + lenpattern.