feat: send VQL image completions through SubLLM vision - #3
Conversation
Messages with image_url use autogrammar-vql/vision. Text-only requests keep the existing OpenRouter client and attribution headers.
|
Weryfikacja lokalna: PYTHONPATH=packages/img2vql/src python -m pytest packages/img2vql/tests/test_llm_contract.py -q przechodzi (9/9), a zdalny check mcp2vql jest zielony. PR nie jest jednak gotowy do merge: ./project/governance-check.sh kończy się GOV-WORKSTREAM-003, bo aktywny ticket-004 ma workstream core, podczas gdy wszystkie zmieniane ścieżki w packages/img2vql/** nie należą do jego dozwolonego scope; pyproject.toml dodatkowo wymaga workstreamu integration. Opis ticketu i jego intent są też niespójne. Należy utworzyć/aktywować prawidłowy ticket integration, przenieść do niego pełny zakres PR-a i uzyskać świeże, zaufane zatwierdzenie. Do tego czasu nie scalono. |
|
Weryfikacja lokalna: |
There was a problem hiding this comment.
Validator approval after policy checks for exact head 2611bf7ece259f5878b073cd0d8d117541e07c8e.
Ticket: ticket-007
Correlation ID: local-autogrammar-vql-pr-3-ticket-007
Model: zai/glm-5.3
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). Diff routes image-bearing VQL completions through SubLLM vision transport while preserving the existing OpenRouter path for text-only requests. The new dependency is pinned to an exact git commit hash. Required check mcp2vql passed, and the new test verifies the SubLLM call contract including credential forwarding and response mapping.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: c7a36fd41cab396686c124404b283a261324f0ac...2611bf7ece259f5878b073cd0d8d117541e07c8e
Change digest: 43926fe02965d8776274ca9843bf40118c1e67f77bcea4a82c20e08d35d1f980
Score: 48/100 (M), estimated 53 min, split recommended: true
Affected services/components: packages/img2vql
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":98,"base_sha":"c7a36fd41cab396686c124404b283a261324f0ac","binary_files":0,"categories":{"code":1,"configuration":1,"docs":1,"tests":1},"change_digest":"43926fe02965d8776274ca9843bf40118c1e67f77bcea4a82c20e08d35d1f980","comparison":"c7a36fd41cab396686c124404b283a261324f0ac...2611bf7ece259f5878b073cd0d8d117541e07c8e","deletions":0,"file_count":4,"files":["packages/img2vql/pyproject.toml","packages/img2vql/src/img2vql/pipeline/llm_client.py","packages/img2vql/tests/test_llm_contract.py","project/ticket-007/README.md"],"head_sha":"2611bf7ece259f5878b073cd0d8d117541e07c8e","service_count":1,"services":["packages/img2vql"]},"assessment_mode":"observed-pr","axes":{"coupling":4,"delivery":2,"scope":2,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":53,"within_budget":false},"impact":{"components":["autogrammar-vql","packages/img2vql","project","subactor"],"files":["autogrammar-vql/vision","packages/img2vql/pyproject.toml","packages/img2vql/src/img2vql/pipeline/llm_client.py","packages/img2vql/tests/test_llm_contract.py","project/ticket-007/README.md","subactor/subllm"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":48,"split":{"parts":[{"estimated_minutes":11,"name":"Implement autogrammar-vql","scope":["autogrammar-vql"]},{"estimated_minutes":11,"name":"Implement packages/img2vql","scope":["packages/img2vql"]},{"estimated_minutes":11,"name":"Implement project","scope":["project"]},{"estimated_minutes":11,"name":"Implement subactor","scope":["subactor"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-007"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-007: feat: send VQL image completions through SubLLM vision</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 97,53 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 53m</text></svg>DECISION D-007-9179
TICKET ticket-007
HEAD_SHA 2611bf7ece259f5878b073cd0d8d117541e07c8e
CORRELATION_ID local-autogrammar-vql-pr-3-ticket-007
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["mcp2vql=PASS"]
INPUT required_checks = ["mcp2vql"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"autogrammar/vql","pull_request":3,"head_sha":"2611bf7ece259f5878b073cd0d8d117541e07c8e","base_sha":"c7a36fd41cab396686c124404b283a261324f0ac","diff_sha256":"7405ca704c1efccaf5452ab2663a926766991c58398ec2d27f3d4c08b3359f4f"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["packages/img2vql/pyproject.toml","packages/img2vql/src/img2vql/pipeline/llm_client.py","packages/img2vql/tests/test_llm_contract.py","project/ticket-007/README.md"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"c7a36fd41cab396686c124404b283a261324f0ac","head_sha":"2611bf7ece259f5878b073cd0d8d117541e07c8e","change_digest":"43926fe02965d8776274ca9843bf40118c1e67f77bcea4a82c20e08d35d1f980","score":48,"complexity":"M","estimated_minutes":53,"split_recommended":true,"services":["packages/img2vql"],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
img2vql messages with
image_urluse SubLLMautogrammar-vql/vision. Text-only requests keep the existing OpenRouter client and X-OpenRouter-Title attribution.Depends on subactor/subllm#25. Tests: 9 passed. No paid requests.
Ticket: ticket-007