Skip to content

Fix many NaNs in conditional parameter-spaces #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shukon wants to merge 1 commit into
base: development
Choose a base branch
from
Draft

Fix many NaNs in conditional parameter-spaces #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pimp/evaluator/local_parameter_importance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ def run(self) -> OrderedDict:
tmp_perf = performance_dict[param][:inc_at] + performance_dict[param][inc_at + 1:]
if delta == 0:
delta = 1 # To avoid division by zero
imp_over_mea = (np.mean(tmp_perf) - performance_dict[param][inc_at]) / delta
imp_over_mea = (np.nanmean(tmp_perf) - performance_dict[param][inc_at]) / delta
imp_over_med = (np.median(tmp_perf) - performance_dict[param][inc_at]) / delta
try:
imp_over_max = (np.max(tmp_perf) - performance_dict[param][inc_at]) / delta
Expand All @@ -273,7 +273,7 @@ def run(self) -> OrderedDict:
str(sum_var_per_tree), len(list(pred_per_tree.values())[0][0]))
for param in performance_dict.keys():
if self.quantify_importance_via_variance:
evaluated_parameter_importance[param] = np.mean(overall_var_per_tree[param])
evaluated_parameter_importance[param] = np.nanmean(overall_var_per_tree[param])
else:
evaluated_parameter_importance[param] = overall_imp[param][0]

Expand Down