fix(header): keep the top menu bar always visible (sticky) on wopee.io (#4239)#237
Merged
Conversation
…239)
The homepage hid the navbar at the top of the page and only slid it in
after scrolling (position: fixed + reveal-on-scroll), while every other
page already used the standard sticky navbar. Unify the homepage with the
rest of the site so the top menu bar stays visible at any scroll position.
- Remove the homepage-only body.is-home navbar override and the
reveal-on-scroll effect; the navbar now uses the default sticky
navbar--fixed-top on all pages (opaque background, no bleed-through).
- Size the hero to calc(100vh - 5rem) so it stays one screen under the
now in-flow 80px navbar (no extra scroll, no layout shift).
Anchor offsets were already handled by section { scroll-margin-top: 80px }.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes autonomous-testing/backlog#4239.
What
Keep the top menu bar always visible while scrolling on all wopee.io pages.
Every page except the homepage already used the standard sticky navbar (
navbar--fixed-top→position: sticky; top: 0). The homepage was the only exception: it hid the navbar at the top of the page and slid it in on scroll (body.is-home→position: fixed+ a reveal-on-scroll effect, added in #236). This unifies the homepage with the rest of the site.Changes
src/css/custom.css— remove the homepage-onlybody.is-home .navbaroverride (fixed +translateY(-100%)hide +navbar--revealed). The homepage now uses the default opaque sticky navbar like every other page.src/pages/index.tsx— remove the reveal-on-scrolluseEffectand theis-homebody class (both existed only to drive that override).src/components/home-page/HomeHeroVibe.tsx— size the hero tomin-h-[calc(100vh-5rem)]so it stays exactly one screen under the now in-flow 80px navbar (no extra scroll).Acceptance criteria
section { scroll-margin-top: 80px }.Verification
yarn buildpasses. Verified via screenshots of the local production build (yarn serve) at the top and scrolled, desktop (1280px) and mobile (390px): navbar stays visible with no overlap in all cases.