Parameterize route correction search depth to avoid infinite loops#173
Open
riron1206 wants to merge 1 commit into
Open
Parameterize route correction search depth to avoid infinite loops#173riron1206 wants to merge 1 commit into
riron1206 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addressed an issue where
route_roadblock_correctionwould hang or take an excessive amount of time due to BFS search on certain maps.This PR makes the search depth limits (
search_depth_backward,search_depth_forward) configurable via Hydra config, allowing users to reduce the search space and avoid infinite loops.Changes
pdm_search_depth_backwardandpdm_search_depth_forwardtodefault_metric_caching.yaml(defaults kept at 15 and 30).MetricCacheProcessor,PDMClosedPlanner,AbstractPDMClosedPlanner, andAbstractPDMPlannerto propagate these parameters down toroute_utils.AbstractPDMClosedPlannerwhere arguments were not passed tosuper().__init__.Impact
navsim/planning.