Remove duplicate dependencies from recent polkadot-stable2412-1 upgrade#3420
Merged
Remove duplicate dependencies from recent polkadot-stable2412-1 upgrade#3420
Conversation
teor2345
commented
Mar 6, 2025
nazar-pc
reviewed
Mar 6, 2025
teor2345
force-pushed
the
remove-substrate-dup-deps
branch
from
f8d0a24 to
4a77746
Compare
teor2345
force-pushed
the
remove-substrate-dup-deps
branch
from
3991ebc to
ab466fb
Compare
nazar-pc
approved these changes
Mar 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes some duplicate dependencies introduced by PR #3394:
libp2p(partial)sp-crypto-hashingitertools(partial)Other duplicate dependencies couldn't be removed, I listed some reasons in ticket #3399.
libp2p fork change
As part of this change, this PR updates our
libp2pfork to libp2p/rust-libp2p#5692We still need to update our substrate fork to use that
libp2pfork, but I want to do that in some follow-up PRs. (It needs a PR with changes to our substrate fork, then a PR updating and patching those changes into subspace.)Close #3399.
Partially fixes #3424.
Code contributor checklist: