Omit more data related to node#34
Merged
isSerge merged 3 commits intotelemetry-frontend-stress-testfrom Sep 23, 2022
Merged
Conversation
i1i1
force-pushed
the
omit-more-data
branch
from
c220bd8 to
8360c2d
Compare
nazar-pc
reviewed
Sep 22, 2022
Member
nazar-pc
left a comment
nazar-pc
left a comment
There was a problem hiding this comment.
It would be great to cherry-pick commits with clippy tweaks and send them upstream, such that we have a smaller diff in case we want to rebase later. Otherwise it might be challenging.
And we certainly want to fix loading screen and show some data.
Member
|
Actually, with this context I'm wondering if we can actually keep the list, but reduce the frequency of delta updates. |
i1i1
force-pushed
the
omit-more-data
branch
from
8360c2d to
0b51332
Compare
Author
|
Force pushed, cause I opened pr with fixing clippy issues in the upstream and also fixed the comment. |
Author
|
Seems like everything works. I had broken local setup :) |
isSerge
added a commit
that referenced
this pull request
Sep 29, 2022
* Disable nodes in memory and hide list and map views * Add the node count to the header * Limit nodes in map view to 1300 * Sort nodes only when receive new best block (#11) * Enable nodes list (#13) * Show the stats view when nodes are disabled * Clean up Header Tile styles * Add node count to Header's shouldComponentUpdate (#19) * Make space pledged visible (#20) * add space pledged tile to Header * update npm packages update tsconfig remove babelrc, babel presets as well as stable package fix svg namespace tag syntax errors fix reference error due to namespace and class component having same name replace tslint with eslint make eslint happier update .nvmrc to 14 update node version to 14 in gh workflow fix eslint warnings due to warnings treated as errors on CI (process.env.CI = true) pretty fix * format space pledged value minor minor * only display space pledged for gemini II * minor * Update map (#21) * Map: render node locations instead of individual nodes * render city details * Merge branch 'telemetry-frontend-stress-test' of github.com:subspace/substrate-telemetry into map-update * Add graceful degradation screen for list view to redirect to polkadot apps (#25) * add DISABLE_NODE_LIST env var * add message on checking balance * update message * Remove unnecessary fields (#26) * Remove some unnecessary fields and fix deserialization * hide validator and implementation columns minor * Ignore broken test Co-authored-by: i1i1 <vanyarybin1@live.ru> * Deployment fixes (#27) * Replace boolean value with number in docker-compose.yml * bump docker to 14 * use createRoot instead of react-dom, remove service worker * update browsers list in package.json * Omit sending node data * fix boolean to disable node list * use window.process_env instead of process.env (#32) * Adjust styles (#33) * Omit more data related to node (#34) * Move omiting data from env to cli * Drain messages to locator if we skip node info * Omit node data delta updates * Add trait for feed message writer * Skip serialization for node update * Send updates every 10 seconds for top bar * Supply period for updates from cli * Update docker compose * Show unique reward address count (#29) * adjust styles for second row * add tile for unique reward address count * add uniq address count into state * add tile for unique address count * fetch uniq address from from subscan API * setup minimal server * fetch address count every 10s * added cors related headers * fetch uniq addr count from our backend instead of subscan * hide uniq addr count component if value is not present * adjust styles * update header markup * provide api url as env variable * rename folder * add service to docker-compose * fetch metadata, remove polkadot.js api * parse string values * add dockerfile for metadata update Dockerfile update debug logs remove logs * Reduce metadata queries (#37) * Reduce metadata queries * addressing PR comments * retry if failed request * Update frontend/src/App.tsx Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com> Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com> * Add second local shard * Use Math.log to calc dot size (#39) * Use Math.log to calc dot size * update comment * pretty fix Co-authored-by: dnieh <danielnieh@gmail.com> Co-authored-by: i1i1 <vanyarybin1@live.ru> Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com>
i1i1
added a commit
that referenced
this pull request
Oct 4, 2022
* Disable nodes in memory and hide list and map views * Add the node count to the header * Limit nodes in map view to 1300 * Sort nodes only when receive new best block (#11) * Enable nodes list (#13) * Show the stats view when nodes are disabled * Clean up Header Tile styles * Add node count to Header's shouldComponentUpdate (#19) * Make space pledged visible (#20) * add space pledged tile to Header * update npm packages update tsconfig remove babelrc, babel presets as well as stable package fix svg namespace tag syntax errors fix reference error due to namespace and class component having same name replace tslint with eslint make eslint happier update .nvmrc to 14 update node version to 14 in gh workflow fix eslint warnings due to warnings treated as errors on CI (process.env.CI = true) pretty fix * format space pledged value minor minor * only display space pledged for gemini II * minor * Update map (#21) * Map: render node locations instead of individual nodes * render city details * Merge branch 'telemetry-frontend-stress-test' of github.com:subspace/substrate-telemetry into map-update * Add graceful degradation screen for list view to redirect to polkadot apps (#25) * add DISABLE_NODE_LIST env var * add message on checking balance * update message * Remove unnecessary fields (#26) * Remove some unnecessary fields and fix deserialization * hide validator and implementation columns minor * Ignore broken test Co-authored-by: i1i1 <vanyarybin1@live.ru> * Deployment fixes (#27) * Replace boolean value with number in docker-compose.yml * bump docker to 14 * use createRoot instead of react-dom, remove service worker * update browsers list in package.json * Omit sending node data * fix boolean to disable node list * use window.process_env instead of process.env (#32) * Adjust styles (#33) * Omit more data related to node (#34) * Move omiting data from env to cli * Drain messages to locator if we skip node info * Omit node data delta updates * Add trait for feed message writer * Skip serialization for node update * Send updates every 10 seconds for top bar * Supply period for updates from cli * Update docker compose * Show unique reward address count (#29) * adjust styles for second row * add tile for unique reward address count * add uniq address count into state * add tile for unique address count * fetch uniq address from from subscan API * setup minimal server * fetch address count every 10s * added cors related headers * fetch uniq addr count from our backend instead of subscan * hide uniq addr count component if value is not present * adjust styles * update header markup * provide api url as env variable * rename folder * add service to docker-compose * fetch metadata, remove polkadot.js api * parse string values * add dockerfile for metadata update Dockerfile update debug logs remove logs * Reduce metadata queries (#37) * Reduce metadata queries * addressing PR comments * retry if failed request * Update frontend/src/App.tsx Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com> Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com> * Add second local shard * Use Math.log to calc dot size (#39) * Use Math.log to calc dot size * update comment * pretty fix Co-authored-by: dnieh <danielnieh@gmail.com> Co-authored-by: i1i1 <vanyarybin1@live.ru> Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr omits sending addition and removal of nodes to a frontend.
But from a frontend I get a page like this:
I suspect that frontend is waiting for info about at least one node, while this pr discards sending any node info at all.