Fix x-carousel demo: use correct BareDOM event names#41
Closed
Fix x-carousel demo: use correct BareDOM event names#41
Conversation
The demo used native event names (change, input, click) instead of BareDOM custom events (x-switch-change, x-form-field-input, select-change, press). Also read values from e.detail instead of e.target. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The x-carousel demo control panel was non-functional because it listened for native DOM events (
change,input,click) instead of BareDOM custom events.Fixes
change+e.target.checkedx-switch-change+e.detail.checkedinput+e.target.valuex-form-field-input+e.detail.valuechange+e.target.valueselect-change+e.detail.valueclickpressNote: Other demo pages have similar issues — this PR fixes only x-carousel. A broader demo audit can follow.
Test plan
🤖 Generated with Claude Code