Fix misc bugs: context menu dismiss, carousel demo, test hint, combobox category#42
Merged
Fix misc bugs: context menu dismiss, carousel demo, test hint, combobox category#42
Conversation
…ari, test hint, combobox category - x-context-menu: Escape and click-outside now dismiss the menu. Moved handlers from the layer element (pointer-events:none, no focus) to document-level listeners, matching x-dropdown's pattern. - x-button: add touch-action:manipulation and -webkit-tap-highlight-color:transparent to the internal button. Fixes missing press events on mobile Safari caused by all:unset resetting touch handling properties. - x-carousel demo: control panel used wrong event names (change instead of x-switch-change, input instead of x-form-field-input, etc.) and wrong detail access (e.target vs e.detail). - x-welcome-tour test: add missing ^js type hint on @detail deref to fix Closure Advanced compilation warning. - x-combobox: fix undefined category in demo gallery (was "input", should be "form"). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
avanelsas
force-pushed
the
fix/misc-bugfixes
branch
from
dbb6ca3 to
df3c48b
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four bugfixes in one PR:
x-context-menu: Escape and click-outside don't dismiss — the layer element has
pointer-events: noneand no focus, so event listeners attached to it never fire. Moved Escape and click-outside handlers to document-level listeners (matching x-dropdown's pattern). Layer-level listeners retained for arrow key navigation and item clicks.x-carousel demo: control panel broken — switches, selects, and form-field inputs used wrong event names (
change/inputinstead ofx-switch-change/x-form-field-input/select-change) and read values frome.targetinstead ofe.detail. Dynamic slide buttons usedclickinstead ofpress.x-welcome-tour test: missing ^js type hint —
(.-stepsCompleted @detail)caused a Closure Advanced compilation warning due to missing type hint on the deref.x-combobox: undefined category in demo gallery — category was
"input"which doesn't exist; changed to"form".Test plan
npx shadow-cljs compile app— zero warningsclj-kondo --lint src test— zero warnings🤖 Generated with Claude Code