A column an exclude list matches is reported as matched, not as "not matched" - #10
Merged
Merged
Conversation
…matched" Three messages named the list setting with a fixed "is not matched by": right for an include list, the opposite of what happened for an exclude list. "public.shipments.driver_phone ... is not matched by column.exclude.list" described a column the exclude list matched, which is why it was missing. Since v0.2.1 the diff rule never raises a pattern-excluded column, so the source-column-not-captured info line is the only message such a column gets, and it read backwards. leftOut(setting) words it per list mode, for the source inventory, the sink column read and the sink table read. Four expectations change, each by that clause; the corpus was edited first and the test failed before the code changed. RefuseRadar's tree, an include-list connector, prints the same 0 / 0 / 159.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Three messages named the list setting after a fixed "is not matched by". Right for an include list; backwards for an exclude list:
public.shipments.driver_phone ... is not matched by column.exclude.listdescribed a column the exclude list matched, which is exactly why the sink was not getting it.iceberg-exclude-listhas promised that sentence since v0.1.Since v0.2.1 (#8) the diff rule never raises a pattern-excluded column, so the
source-column-not-capturedinfo line is the only message such a column gets. It has to read right; this is the item the #8 review put ahead of the per-rule filter.The fix
leftOut(setting)inengine.go: "is not matched by column.include.list" or "is matched by column.exclude.list", using the sameexcludes()helper asedit(). Applied tosource-column-not-captured,sink-column-not-capturedandsink-table-not-captured(the last fortable.exclude.list, which no corpus entry exercises yet).Corpus
Four expectations change, each by that one clause:
iceberg-exclude-listand the threediff-exclude-list-*entries. They were edited by hand first; the test failed on all four before the code changed.Verified
gofmt,vet,build,testgreen ingolang:1.25-bookworm. RefuseRadar (include-list connector): unchanged,0 error(s), 0 warning(s), 159 info.After merging
Tag
v0.2.2. Nothing to bump in RefuseRadar: its connector is an include list.