Pack DevExpress package - #14
Conversation
5546342 to
d8d0c82
Compare
There was a problem hiding this comment.
Pull request overview
This pull request restructures the TinyChat project to create a separate NuGet package for DevExpress-specific controls. The main TinyChat library is moved from src/ to TinyChat/, and a new TinyChat.DevExpress project is created containing DevExpress WinForms implementations.
Changes:
- Restructured project layout: moved core library from
src/toTinyChat/directory - Created new
TinyChat.DevExpresspackage with DevExpress-specific controls (message controls, input control, split container, message formatter) - Added comprehensive test coverage for message formatters with 977 new test cases
- Moved DevExpress controls from demo project to new package and updated namespaces from
DevExpressDemotoTinyChat - Replaced embedded SVG resources with inline SVG constants to avoid external resource dependencies
Reviewed changes
Copilot reviewed 19 out of 56 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| TinyChat.sln | Updated solution to reference TinyChat/TinyChat.csproj instead of src/TinyChat.csproj, added TinyChat.DevExpress project |
| TinyChat/TinyChat.csproj | Added exclusion pattern for DevExpress folder to prevent conflicts |
| TinyChat.DevExpress/TinyChat.DevExpress.csproj | New project file for DevExpress package with DevExpress.Win dependency |
| TinyChat/SubControls/*.cs | New core library controls (ChatControl, message controls, input controls, interfaces) |
| TinyChat/Messages/*.cs | New message types and content classes |
| TinyChat.DevExpress/SubControls/*.cs | DevExpress implementations moved from demo, namespace changed to TinyChat |
| Tests/*.cs | Added comprehensive test suites for PlainTextMessageFormatter and SimplifiedHtmlMessageFormatter |
| .github/workflows/CI.yml | Updated to build and pack both TinyChat and TinyChat.DevExpress packages |
| WinFormsDemo/WinFormsDemo.csproj | Updated project reference path |
| DevExpressDemo/DevExpressDemo.csproj | Added reference to new TinyChat.DevExpress project |
Files not reviewed (1)
- DevExpressDemo/DXDemoForm.Designer.cs: Language not supported
Comments suppressed due to low confidence (1)
Tests/Tests.csproj:21
- This project reference points to a non-existent path
..\..\src\TinyChat.csproj. The project has been moved toTinyChat/TinyChat.csproj, so this should be..\TinyChat\TinyChat.csprojinstead. Additionally, this creates a duplicate reference since line 23 already correctly references..\TinyChat\TinyChat.csproj. This line should be removed entirely.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| pull_request: | ||
| branches: [ "main", "master" ] | ||
| paths: [ 'src/**' ] | ||
| paths: [ 'src/**', 'TinyChat.DevExpress/**' ] |
There was a problem hiding this comment.
The path src/** in the paths filter is incorrect. Based on the solution file changes, the TinyChat project has been moved from src/ to TinyChat/. This should be TinyChat/** instead.
| push: | ||
| branches: [ "main", "master" ] | ||
| paths: [ 'src/**', '.github/workflows/CI.yml' ] | ||
| paths: [ 'src/**', 'TinyChat.DevExpress/**', '.github/workflows/CI.yml' ] |
There was a problem hiding this comment.
The path src/** in the paths filter is incorrect. Based on the solution file changes, the TinyChat project has been moved from src/ to TinyChat/. This should be TinyChat/** instead.
| # Visual Studio Version 17 | ||
| VisualStudioVersion = 17.14.36109.1 | ||
| # Visual Studio Version 18 | ||
| VisualStudioVersion = 18.3.11505.172 d18.3 |
There was a problem hiding this comment.
The VisualStudioVersion is set to "18.3.11505.172 d18.3" which includes what appears to be a typo with "d18.3" at the end. This should likely be just the version number without the extra suffix. Visual Studio 2025 (version 18.x) versions typically don't include this suffix.
| VisualStudioVersion = 18.3.11505.172 d18.3 | |
| VisualStudioVersion = 18.3.11505.172 |
| dotnet restore ./TinyChat/TinyChat.csproj | ||
| dotnet restore ./TinyChat.DevExpress/TinyChat.DevExpress.csproj |
There was a problem hiding this comment.
The path ./src/TinyChat.csproj is incorrect. Based on the solution file changes, the TinyChat project has been moved from src/ to TinyChat/. This path should be ./TinyChat/TinyChat.csproj instead.
| dotnet build ./TinyChat/TinyChat.csproj --no-restore --configuration=Release /p:Version=${{steps.gitversion.outputs.semVer}} | ||
| dotnet build ./TinyChat.DevExpress/TinyChat.DevExpress.csproj --no-restore --configuration=Release /p:Version=${{steps.gitversion.outputs.semVer}} |
There was a problem hiding this comment.
The path ./src/TinyChat.csproj is incorrect. Based on the solution file changes, the TinyChat project has been moved from src/ to TinyChat/. This path should be ./TinyChat/TinyChat.csproj instead.
| dotnet pack ./TinyChat/TinyChat.csproj --output nupkgs --configuration=Release --no-restore --no-build /p:PackageVersion=${{steps.gitversion.outputs.semVer}} | ||
| dotnet pack ./TinyChat.DevExpress/TinyChat.DevExpress.csproj --output nupkgs --configuration=Release --no-restore --no-build /p:PackageVersion=${{steps.gitversion.outputs.semVer}} |
There was a problem hiding this comment.
The path ./src/TinyChat.csproj is incorrect. Based on the solution file changes, the TinyChat project has been moved from src/ to TinyChat/. This path should be ./TinyChat/TinyChat.csproj instead.
No description provided.