Sync forced CRAN changes#488
Open
DavisVaughan wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #488 +/- ##
=========================================
Coverage ? 60.07%
=========================================
Files ? 30
Lines ? 7023
Branches ? 0
=========================================
Hits ? 4219
Misses ? 2804
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In hopes to get this un-ORPHANED, I've synced with CRAN's version, 4.1.0.1, and the only difference that I could find was this change regarding the size of the char array.
@awalker89 if you happen to have the old email of the original requests made by CRAN, I'd be interested to take a look and see if anything else is required.
I realize that the version you submitted to CRAN was 4.1.0, and the last commit before you sent to CRAN seems to be this one: 7f96f21
Then CRAN bumped that version to 4.1.0.1.
In the meantime, you bumped your github version to 4.1.1 and added more commits, which is what I worked off of. I think that it would be fine to just add this PR on top of the current master branch, and then send that to CRAN to get this un-ORPHANED.