fix: incremental append and partition_by support for Iceberg Python#662
Conversation
figuring out how to fix this without tests is impossible...
f720454 to
48c78d2
Compare
|
Hey @yotahk, |
3e56fbf to
64d8ece
Compare
|
thanks, will take a look next week. |
Hey @yotahk, |
|
Hey @yotahk, just noticed that you run the CI, fixed the indentation error. |
|
Thanks for the update, I kicked the CI again. Let's see... |
Hey @yotahk, everything looks ok? If yes, I'll remove the test file and update the changelog |
yotahk
left a comment
There was a problem hiding this comment.
Adding one comment. Also, would you update CHANGELOG.md?
|
@yotahk all done |
|
@akmalsoliev Would you also fix this too?
|
yeah, mb, skipped that. |
|
hey @yotahk, pinging to see if there are any updates. |
|
Hey sorry I didn't have much time to review last week. Diff looks good to me, kicked CI. |
|
Merged, thanks for your patience. |
Description
Checklist
CHANGELOG.mdand added information about my change to the "dbt-glue next" section.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.