-
Notifications
You must be signed in to change notification settings - Fork 28
Remove inline container build from vended cdk-stack.ts #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tejaskash
wants to merge
4
commits into
preview
Choose a base branch
from
fix/harness-container-encapsulation-cli
base: preview
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7d22725
Remove DockerImageAsset from vended cdk-stack.ts
tejaskash 5e570f1
Support both old and new CDK output key patterns for harness outputs
tejaskash b43230e
Align vended CDK field names with HarnessRoleConfig interface
tejaskash e6dc7d0
Add tests for new AgentCoreHarnessEnvironment CDK output key patterns
tejaskash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -102,15 +102,19 @@ export class HarnessDeployer implements ImperativeDeployer<HarnessDeployedStateM | |
| harnessSpec = validated.data; | ||
| } catch (err) { | ||
| const message = err instanceof Error ? err.message : String(err); | ||
| return { success: false, error: `Failed to read harness.json for "${entry.name}": ${message}`, state: resultState }; | ||
| return { | ||
| success: false, | ||
| error: `Failed to read harness.json for "${entry.name}": ${message}`, | ||
| state: resultState, | ||
| }; | ||
| } | ||
|
|
||
| // Resolve role ARN from CDK outputs | ||
| const roleArn = resolveRoleArn(entry.name, cdkOutputs); | ||
| if (!roleArn) { | ||
| return { | ||
| success: false, | ||
| error: `Could not find role ARN in CDK outputs for harness "${entry.name}". Expected output key starting with "ApplicationHarness${toPascalId(entry.name)}RoleArn".`, | ||
| error: `Could not find role ARN in CDK outputs for harness "${entry.name}". Expected output key starting with "ApplicationHarness${toPascalId(entry.name)}RoleArn" or "ApplicationHarness${toPascalId(entry.name)}RoleRoleArn".`, | ||
| state: resultState, | ||
| }; | ||
| } | ||
|
|
@@ -265,17 +269,20 @@ export class HarnessDeployer implements ImperativeDeployer<HarnessDeployedStateM | |
| /** | ||
| * Resolve the IAM role ARN for a harness from CDK stack outputs. | ||
| * | ||
| * The CDK construct exports the role ARN with a key matching the pattern: | ||
| * ApplicationHarness{PascalName}RoleArn... | ||
| * Supports two construct tree layouts: | ||
| * Old (AgentCoreHarnessRole directly under Application): | ||
| * ApplicationHarness{PascalName}RoleArnOutput... | ||
| * New (AgentCoreHarnessEnvironment wrapping AgentCoreHarnessRole): | ||
| * ApplicationHarness{PascalName}RoleRoleArnOutput... | ||
| */ | ||
| function resolveRoleArn(harnessName: string, cdkOutputs?: Record<string, string>): string | undefined { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ordering matters here: |
||
| if (!cdkOutputs) return undefined; | ||
|
|
||
| const pascalName = toPascalId(harnessName); | ||
| const prefix = `ApplicationHarness${pascalName}RoleArn`; | ||
| const prefixes = [`ApplicationHarness${pascalName}RoleRoleArn`, `ApplicationHarness${pascalName}RoleArn`]; | ||
|
|
||
| for (const [key, value] of Object.entries(cdkOutputs)) { | ||
| if (key.startsWith(prefix)) { | ||
| if (prefixes.some(p => key.startsWith(p))) { | ||
| return value; | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Consider adding a test case where both old and new output keys are present in
cdkOutputs(e.g. both...RoleRoleArn...and...RoleArn...keys). This would document the precedence contract and guard against regressions if the prefix array order changes. Same applies to theharness-mapper.test.tscounterpart.