fix: duplicate header flash and help menu truncation#955
Open
fix: duplicate header flash and help menu truncation#955
Conversation
…loses aws#637) - Return null during brief transitional phases to prevent Ink from rendering a header that gets immediately replaced by a different frame - Consolidate CreateScreen phases into a single Screen mount - Make help menu description width responsive to terminal size - Remove hardcoded 50-char description truncation limit
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-955-tarball/aws-agentcore-0.9.1.tgz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #895
Closes #637
Changes
nullduring brief AWS config transitional phases (checking/detecting/saving) instead of rendering a<Screen>that gets immediately replacednullduringcheckingphase; consolidate all other phases into a single<Screen>mount so Ink doesn't output multiple frames with the same headerMAX_DESC_WIDTH = 50with dynamic width computed from terminal columnsruncommand descriptionRoot Cause
Ink (React for terminal) doesn't use an alternate screen buffer in non-interactive mode. When a component renders briefly during a transitional phase then re-renders with different content, both frames get written to stdout — causing the title to appear twice.
Test plan
agentcore createfrom CLI — verify single "AgentCore Create" headeragentcore deployfrom CLI — verify single "AgentCore Deploy" headeragentcoreTUI, navigate to deploy — verify single header