feat: add agentcore-cli User-Agent to all API calls#960
feat: add agentcore-cli User-Agent to all API calls#960notgitika wants to merge 1 commit intoaws:previewfrom
Conversation
223b6cd to
39e1108
Compare
Base branch mismatch — PR would regress version on
|
User-Agent coverage is incompleteThe PR description says:
But These cover real user-invoked API surface ( Options
|
|
updating the missed call sites using option 2 |
39e1108 to
4851166
Compare
| export async function startPolicyGeneration( | ||
| options: StartPolicyGenerationOptions | ||
| ): Promise<StartPolicyGenerationResult> { | ||
| const client = new BedrockAgentCoreControlClient({ |
There was a problem hiding this comment.
thanks for updating this to use the shared helper!
| } | ||
|
|
||
| function createAgentCoreClient(region: string, headers?: Record<string, string>): BedrockAgentCoreClient { | ||
| export function createAgentCoreClient(region: string, headers?: Record<string, string>): BedrockAgentCoreClient { |
There was a problem hiding this comment.
not related to this change, but I wonder if we should cache the client for potential connection re-use.
Summary
Sends
agentcore-cli/<version>on all API requests so the service can differentiate CLI vs console vs curl traffic.Test plan