Conversation
There was a problem hiding this comment.
I checked this. Looks like formatter just reshuffle all the function.
| /// ../mpl/ComAmazonawsKms/src/Index.dfy(31,3) | ||
| pub fn DafnyUserAgentSuffix(runtime: &Sequence<DafnyCharUTF16>) -> Sequence<DafnyCharUTF16> { | ||
| let mut version: Sequence<DafnyCharUTF16> = string_utf16_of("1.11.0"); | ||
| let mut version: Sequence<DafnyCharUTF16> = string_utf16_of("2.0.0"); |
There was a problem hiding this comment.
shouldn't this be 1.2.4?
There was a problem hiding this comment.
Since this is dafny generated code, we only put same value here for all runtime. The release readme does not tell me to update this manually. If we use this version value, then I can update the release readme to say to manually update this. But, if there is no use case for the version value then we can leave it as-is as I prefer less manual changes possible while doing the release.
There was a problem hiding this comment.
got it. that's unfortunate since it makes no sense why the 1.2.4 release will make calls to kms with a 2.0.0 or 1.11.0 useragent string
2 participants
Issue #, if available:
Description of changes:
Releasing esdk rust v1.2.4 in https://crates.io/crates/aws-esdk/versions
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.