fix(auth): Prevent privilege escalation via self-writable Cognito custom attribute#165
Open
amalleramzn wants to merge 1 commit intomasterfrom
Open
fix(auth): Prevent privilege escalation via self-writable Cognito custom attribute#165amalleramzn wants to merge 1 commit intomasterfrom
amalleramzn wants to merge 1 commit intomasterfrom
Conversation
…tom attribute Add WriteAttributes restriction to Cognito UserPoolClient to block client-side writes to custom:deployment_admin and custom:wheel_group_id. Add server-side email verification against DEPLOYMENT_ADMIN_EMAILS in the authorizer, middleware, and deployment admin operations as defense-in-depth. Admin API calls (deploy script, Lambda functions) bypass WriteAttributes and continue to work. sim: https://t.corp.amazon.com/P400495385
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Tighten Cognito UserPoolClient attribute permissions and add server-side verification for deployment admin access. Adds WriteAttributes to restrict which attributes users can self-modify, and introduces an admin email allowlist check in the authorizer, middleware, and admin operations. Existing deployment scripts and Lambda functions are unaffected.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.