Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
=======================================
Coverage 92.30% 92.30%
=======================================
Files 15 15
Lines 2626 2626
Branches 2626 2626
=======================================
Hits 2424 2424
Misses 152 152
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Simon Marty <martysi@amazon.com>
Signed-off-by: Simon Marty <martysi@amazon.com>
| working-directory: aws_secretsmanager_caching | ||
| run: cargo bench --bench benchmark -- --output-format bencher | tee ../bench-result.txt | ||
|
|
||
| - name: Download previous benchmark data |
There was a problem hiding this comment.
for my edification: why is this being removed? Does benchmark-action/github-action-benchmark@v1 do this for you?
There was a problem hiding this comment.
Sorry it took a minute to respond, I figured I could show you on my fork.
Here's a run from a push to main on the fork: https://github.com/simonmarty/aws-secretsmanager-agent/actions/runs/24808395936/job/72763846297
Here's a run against a no-op pull request I created on my fork, it correctly retrieves the test run results simonmarty#61 https://github.com/simonmarty/aws-secretsmanager-agent/actions/runs/24855062991/job/72765608319?pr=61
This does make me realize that there must be some variance in the performance of GitHub actions hosted runners. It's failing the regression check despite there not being any code changes. I'm going to set the workflow to be non-blocking and just post comments. Maybe up the tolerance threshold to the default of 200%.
Signed-off-by: Simon Marty <martysi@amazon.com>
Signed-off-by: Simon Marty <martysi@amazon.com>
Description
Why is this change being made?
What is changing?
We keep the two separate because they have different levels of permissions.
Related Links
Testing
Tested on fork https://simonmarty.github.io/aws-secretsmanager-agent/dev/bench/
Made a mock PR https://github.com/simonmarty/aws-secretsmanager-agent/actions/runs/24591788832
How was this tested?
When testing locally, provide testing artifact(s):
Reviewee Checklist
Update the checklist after submitting the PR
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
If not, why: No change
If not, why:
If not, why:
If not, why: No change
If not, why: No breaking changes.
Reviewer Checklist
All reviewers please ensure the following are true before reviewing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.