Expand auth error code detection for PGBouncer, MSSQL, and Db2 proxies#332
Merged
simonmarty merged 1 commit intoaws:v2from Apr 30, 2026
Merged
Conversation
a1e24d9 to
a06e6b1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #332 +/- ##
============================================
+ Coverage 82.71% 83.02% +0.31%
- Complexity 148 156 +8
============================================
Files 12 12
Lines 376 377 +1
Branches 48 50 +2
============================================
+ Hits 311 313 +2
Misses 58 58
+ Partials 7 6 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
harsheejshah
approved these changes
Apr 29, 2026
harsheejshah
left a comment
There was a problem hiding this comment.
Approving post our offline discussion of doing a fast follow to re-evaluate error codes and have a more robust approach for these
simonmarty
reviewed
Apr 29, 2026
simonmarty
reviewed
Apr 30, 2026
simonmarty
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Why is this change being made?
What is changing?
Related Links
Testing
How was this tested?
When testing locally, provide testing artifact(s):
mvn clean testoutput:Tests run: 66, Failures: 0, Errors: 0, Skipped: 0 — BUILD SUCCESSReviewee Checklist
Update the checklist after submitting the PR
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
Reviewer Checklist
All reviewers please ensure the following are true before reviewing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.