You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove 4 explicit methods with no additional logic, now covered by passthrough: create_oauth2_credential_provider,create_api_key_credential_provider, update_workload_identity, get_workload_identity
Retain explicit methods that have additional logic: get_workload_access_token, create_workload_identity, complete_resource_token_auth, get_token, get_api_key
Note: create_oauth2_credential_provider_and_wait and delete_oauth2_credential_provider_and_wait were originally part of this change, but were removed. Though the service model defines a status field on the GetOauth2CredentialProvider response, integ tests revealed that the API was not returning any status field. The provider became available synchronously after creation. Polling methods were timing out waiting for a status that never appears, even when provider was created successfully. Thus the *_and_wait methods were dead code.
Test plan:
Unit tests (24 total):
Existing tests updated to use getattr passthrough calling convention (kwargs instead of positional dict)
�[1msrc/bedrock_agentcore/services/identity.py�[0m:0: IdentityClient.create_oauth2_credential_provider: �[33mPublic object was removed�[39m
�[1msrc/bedrock_agentcore/services/identity.py�[0m:0: IdentityClient.create_api_key_credential_provider: �[33mPublic object was removed�[39m
�[1msrc/bedrock_agentcore/services/identity.py�[0m:0: IdentityClient.update_workload_identity: �[33mPublic object was removed�[39m
�[1msrc/bedrock_agentcore/services/identity.py�[0m:0: IdentityClient.get_workload_identity: �[33mPublic object was removed�[39m
Note: This is an automated static analysis check. Some flagged changes may be intentional.
Please confirm each item is expected and, if so, add a migration note to CHANGELOG.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
__getattr__passthrough withaccept_snake_case_kwargsto IdentityClientcreate_oauth2_credential_provider,create_api_key_credential_provider,update_workload_identity,get_workload_identityget_workload_access_token,create_workload_identity,complete_resource_token_auth,get_token,get_api_keyNote:
create_oauth2_credential_provider_and_waitanddelete_oauth2_credential_provider_and_waitwere originally part of this change, but were removed. Though the service model defines a status field on theGetOauth2CredentialProviderresponse, integ tests revealed that the API was not returning any status field. The provider became available synchronously after creation. Polling methods were timing out waiting for a status that never appears, even when provider was created successfully. Thus the*_and_waitmethods were dead code.Test plan:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.