Modifying existing patches and adding sagemaker integration patch - #19
Conversation
| common/embedded-api.diff | ||
| common/remove-disable-prompting-for-non-trusted-urls-option.diff | ||
| common/suppress-known-errors-script.diff | ||
| common/update-csp.diff |
There was a problem hiding this comment.
If this is a common patch why it's not included in other series files? If there are concerns that it can impact other consumers we can keep it in the sagemaker folder for now (but let's create a task to move it to common and run appropriate tests).
There was a problem hiding this comment.
Moving it under sagemaker patches path for now, will add based on testing outcome with other consumers.
| }); | ||
| } | ||
| + | ||
| + if (env['EXTENSIONS_GALLERY']) { |
There was a problem hiding this comment.
Can we document the support for this variable in the header of the patch?
There was a problem hiding this comment.
Sure, adding in a new revision
There was a problem hiding this comment.
I don't think these changes are needed as we hook into the Localization service here:
Can you please check if the expected texts are displayed without a need to modify NLS files?
There was a problem hiding this comment.
Seems like we need this override. Localisation doesn't seem to replace the git extension configurations
2 participants
Description of changes:
Reorganised sagemaker patches as follows:
Testing: Created a Sagemaker distribution image using all sagemaker patches and created a code editor application on Sagemaker Studio using that.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.