Skip to content

Allow usage of proposed APIs #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azmkercso merged 1 commit into from
Aug 5, 2025
Merged

Allow usage of proposed APIs #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions patches/common/proposed-api.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
Original source: https://github.com/coder/code-server/blob/v4.101.2/patches/proposed-api.diff

Unconditionally enable the proposed API, and disable the `isProposedApiEnabled` check.

Index: third-party-src/src/vs/workbench/services/extensions/common/extensions.ts
===================================================================
--- third-party-src.orig/src/vs/workbench/services/extensions/common/extensions.ts
+++ third-party-src//src/vs/workbench/services/extensions/common/extensions.ts
@@ -314,10 +314,7 @@ function extensionDescriptionArrayToMap(
}

export function isProposedApiEnabled(extension: IExtensionDescription, proposal: ApiProposalName): boolean {
- if (!extension.enabledApiProposals) {
- return false;
- }
- return extension.enabledApiProposals.includes(proposal);
+ return true;
}

export function checkProposedApiEnabled(extension: IExtensionDescription, proposal: ApiProposalName): void {
Index: third-party-src/src/vs/workbench/services/extensions/common/extensionsProposedApi.ts
===================================================================
--- third-party-src.orig/src/vs/workbench/services/extensions/common/extensionsProposedApi.ts
+++ third-party-src/src/vs/workbench/services/extensions/common/extensionsProposedApi.ts
@@ -31,7 +31,7 @@ export class ExtensionsProposedApi {

this._envEnabledExtensions = new Set((_environmentService.extensionEnabledProposedApi ?? []).map(id => ExtensionIdentifier.toKey(id)));

- this._envEnablesProposedApiForAll =
+ this._envEnablesProposedApiForAll = true ||
!_environmentService.isBuilt || // always allow proposed API when running out of sources
(_environmentService.isExtensionDevelopment && productService.quality !== 'stable') || // do not allow proposed API against stable builds when developing an extension
(this._envEnabledExtensions.size === 0 && Array.isArray(_environmentService.extensionEnabledProposedApi)); // always allow proposed API if --enable-proposed-api is provided without extension ID

2 changes: 2 additions & 0 deletions patches/sagemaker.series
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ common/remove-vsda.diff
common/embedded-api.diff
common/remove-disable-prompting-for-non-trusted-urls-option.diff
common/suppress-known-errors-script.diff
common/service-worker-fix.diff
common/proposed-api.diff
web-server/suppress-known-errors-build-integration.diff
web-server/local-storage.diff
web-server/base-path.diff
Expand Down
1 change: 1 addition & 0 deletions patches/web-embedded-with-terminal.series
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ common/embedded-api.diff
common/remove-disable-prompting-for-non-trusted-urls-option.diff
common/suppress-known-errors-script.diff
common/service-worker-fix.diff
common/proposed-api.diff
web-embedded/readd-workbench.diff
web-embedded/suppress-known-errors-build-integration.diff
web-embedded/disable-built-in-walkthroughs-from-c.diff
Expand Down
1 change: 1 addition & 0 deletions patches/web-embedded.series
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ common/embedded-api.diff
common/remove-disable-prompting-for-non-trusted-urls-option.diff
common/suppress-known-errors-script.diff
common/service-worker-fix.diff
common/proposed-api.diff
web-embedded/readd-workbench.diff
web-embedded/suppress-known-errors-build-integration.diff
web-embedded/disable-built-in-walkthroughs-from-c.diff
Expand Down
1 change: 1 addition & 0 deletions patches/web-server.series
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ common/embedded-api.diff
common/remove-disable-prompting-for-non-trusted-urls-option.diff
common/suppress-known-errors-script.diff
common/service-worker-fix.diff
common/proposed-api.diff
web-server/suppress-known-errors-build-integration.diff
web-server/local-storage.diff
web-server/base-path.diff
Expand Down