feat: add AIDLC Design Reviewer tool with monorepo support#152
feat: add AIDLC Design Reviewer tool with monorepo support#152
Conversation
Add AI-powered design review tool for AIDLC projects with intelligent workspace detection for monorepo environments. Features: - Multi-agent design review (Critique, Alternatives, Gap Analysis) - Quality scoring with weighted severity analysis - Two deployment modes: CLI tool and Claude Code hook (experimental) - Comprehensive test suite (743 tests) - Full documentation and installation guides Installation improvements: - Smart workspace detection in all installers (Bash/PowerShell) - Priority-based detection: .git > aidlc-rules > pyproject.toml - Automatic detection from scripts/aidlc-designreview/tool-install/ - Backward compatible with standalone usage - Visual feedback showing detected workspace directory Documentation: - Added "Supporting Tools" section to main README.md - Links to design reviewer and evaluator documentation - Installation instructions for both CLI and hook modes - MONOREPO_INSTALLATION.md with detailed migration notes Modified files: - README.md: Added Supporting Tools section - tool-install/install-linux.sh: Smart workspace detection - tool-install/install-mac.sh: Smart workspace detection - tool-install/install-windows.sh: Smart workspace detection - tool-install/install-windows.ps1: Smart workspace detection New files: - scripts/aidlc-designreview/: Complete tool with src/, tests/, docs/ - MONOREPO_INSTALLATION.md: Migration and testing documentation - MIGRATION_NOTES.md: Migration checklist and status Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com>
|
I tested the AIDLC Design Reviewer as a standalone CLI tool against the design artifacts from a personal AI-DLC project. It produced 27 findings (1 critical, 5 high, 21 medium) across three AI agents: critique, alternatives, and gap analysis. The findings were legitimate. It caught real issues like hardcoded single-user auth via Lambda env vars, synchronous Bedrock calls inside a 30-second API Gateway timeout, unbounded DynamoDB scans, large document text stored inline exceeding the 400KB item limit, and localStorage token storage exposing XSS risk. These weren't generic suggestions — they referenced specific business rules and entities from my design docs. The HTML report was clean: self-contained single file, collapsible sections, severity filters, color-coded badges, and a clear executive summary with a recommended action. The tool also ships with a Claude Code pre-tool-use hook for automatic design review during development. Still need to test that part because Claude Code wasn't working in my environment at the time. Overall, the Design Reviewer tool works well and produces actionable, project-specific feedback. |
There was a problem hiding this comment.
Semgrep OSS found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Markdown Lint (2154 → 0 errors across 58 files): - Add <!-- markdownlint-disable MD060 --> to docs with HTML in tables - Add <!-- markdownlint-disable MD041 MD051 --> to docs with license comment headers and inline HTML links - Align all table pipes to "aligned" style per project markdownlint config - Fix MD040: add language specifiers to opening fenced code blocks - Fix MD031/MD032/MD022: add blank lines around fences, lists, headings - Add .markdownlint.json to templates/ disabling MD013/MD036/MD060 for report template file (intentionally long disclaimer lines) - Fix tool-install/README.md: convert bold labels to h4, wrap long lines - Add <!-- markdownlint-disable MD041 --> to AI agent prompt files (YAML frontmatter files without H1 by design) Grype vulnerabilities (7 packages in uv.lock): - cryptography 46.0.5 → 47.0.0 (GHSA-p423-j2cm-9vmq, GHSA-m959-cc7f-wv43) - pyjwt 2.11.0 → 2.12.1 (GHSA-752w-5fwx-jx9f) - python-multipart 0.0.22 → 0.0.27 (GHSA-mj87-hwqh-73pj) - pytest 9.0.2 → 9.0.3 (GHSA-6w46-j5rx-g56g) - requests 2.32.5 → 2.33.1 (GHSA-gc5v-m9x4-r6x2) - pygments 2.19.2 → 2.20.0 (GHSA-5239-wwwm-4pmq) Semgrep OSS: was passing (the 20+ findings were pre-existing repo-wide alerts unrelated to this PR's code changes). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Add AI-powered design review tool for AIDLC projects with intelligent workspace detection for monorepo environments.
Features:
Installation improvements:
Documentation:
New files:
Summary
Introduces automated design review capability for AIDLC projects using
Claude AI models via AWS Bedrock. Analyzes design artifacts and produces
actionable reports with severity-graded findings, alternative approaches,
and gap analysis.
Key Features:
Directory Structure in Target Repository
Files
Core Application Files
foundation/- Config, logging, exceptions, prompts, patterns (13 modules)validation/- Structure validation, artifact discovery (6 modules)parsing/- Artifact parsers (5 modules)ai_review/- AI agents and orchestration (8 modules)reporting/- Report builders and formatters (7 modules)orchestration/- Pipeline orchestrator (2 modules)cli/- CLI entry point (3 modules)__init__.py- Package initializationpy.typed- Type checking markerConfiguration Files
patterns/- 15 architectural pattern definitions (markdown)prompts/- 3 agent system prompts (critique, alternatives, gap)default-config.yaml- Bundled default configurationexample-config.yaml- Annotated user reference configurationHook Installation System
lib/- 7 library modules:logger.sh- Logging functionsconfig-defaults.sh- Default configuration valuesconfig-parser.sh- YAML parser with fallbacksuser-interaction.sh- User promptsreview-executor.sh- Artifact discovery and reviewreport-generator.sh- Report parsing and generationaudit-logger.sh- Audit trail logginghooks/- Hook entry point:pre-tool-use- Main hook scripttemplates/- Report templates:design-review-report.md- Report templateinstall-mac.sh- macOS installerinstall-linux.sh- Linux installer (symlink to macOS)install-windows.ps1- Windows PowerShell installerinstall-windows.sh- Windows Git Bash/WSL installerreview-config.yaml.example- Example hook configurationREADME.md- Technical documentationTest Suite
unit1_foundation/- 14 files, ~284 testsunit2_validation/- 7 files, ~122 testsunit3_parsing/- 6 files, ~71 testsunit4_ai_review/- 10 files, ~103 testsunit5_reporting/- 5 files, ~95 testsunit5_orchestration/- 2 files, ~15 testsunit5_cli/- 3 files, ~19 testsfunctional/- 4 files, ~34 testsconftest.py- Pytest configuration and fixtures__init__.py- Test package initializationDocumentation
README.md - Main project documentation (38KB, comprehensive)
INSTALLATION.md - Hook installation guide (16KB)
CHANGELOG.md - Version history and release notes
docs/ - Additional documentation
hook/TESTING.md- Hook testing guidesecurity/- Security documentation directoryAWS_BEDROCK_SECURITY_GUIDELINES.mdSYSTEM_ARCHITECTURE.mdTHREAT_MODEL.mdai-security/- AI security documentationBEDROCK_GUARDRAILS.mdarchitecture/- Architecture documentationLegal and License Files
Project Configuration
pyproject.toml - Python project configuration
uv.lock - Dependency lock file (for reproducible builds)
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Test Plan
CLI Tool Tests
uv synccompletes successfullydesign-reviewer --versionworksmypypasses with no errorsHook Installation Tests
./tool-install/install-mac.shsucceeds./tool-install/install-linux.shsucceeds.\tool-install\install-windows.ps1succeeds./tool-install/install-windows.shsucceedsTEST_MODE=1 .claude/hooks/pre-tool-useworksDocumentation Tests
Security Tests
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.